Opened 4 years ago

Closed 4 years ago

#23839 closed defect (fixed)

Fix reference manual index for partn_ref

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.1
Component: documentation Keywords:
Cc: jhpalmieri Merged in:
Authors: Jeroen Demeyer Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: f1d2109 (Commits, GitHub, GitLab) Commit: f1d2109bbf3f2cc42046286752a3f2c3468ee16d
Dependencies: Stopgaps:

Status badges

Change History (6)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/fix_reference_manual_index_for_partn_ref

comment:2 Changed 4 years ago by git

  • Commit set to f1d2109bbf3f2cc42046286752a3f2c3468ee16d

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f1d2109Reference manual: fix groups index

comment:3 Changed 4 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Status changed from new to needs_review

comment:4 Changed 4 years ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

It looks okay to me. To be honest, the title "Partition Refinement" doesn't mean much to me, and the opening paragraph of the "Canonical augmentation" page is rather opaque, plus there are no helpful examples. So while I don't mind adding these pages to the reference manual, I lament their general state and I don't think they really contribute much. (None of this is the fault of the branch here.)

comment:5 Changed 4 years ago by jdemeyer

I agree. I also have no idea what partn_ref is about...

At least I made it a separate section so it's easy to ignore.

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/fix_reference_manual_index_for_partn_ref to f1d2109bbf3f2cc42046286752a3f2c3468ee16d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.