Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#23831 closed enhancement (fixed)

py3: some care for .keys()[...]

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.1
Component: python3 Keywords:
Cc: tscrim, jdemeyer, jhpalmieri, embray Merged in:
Authors: Frédéric Chapoton Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: 950d6da (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by chapoton)

similar to #23824, part of #15981

Change History (10)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/23831
  • Commit set to 30b9645d97aa3bb89bdd0a1f503f104fc5c859ce
  • Status changed from new to needs_review

New commits:

​30b9645py3: some care for .keys()[...]

comment:2 Changed 3 years ago by chapoton

  • Description modified (diff)

comment:3 Changed 3 years ago by chapoton

  • Description modified (diff)

comment:4 Changed 3 years ago by git

  • Commit changed from 30b9645d97aa3bb89bdd0a1f503f104fc5c859ce to ac9ff0bf89bad437e997ea9b28cc671af1bc8481

Branch pushed to git repo; I updated commit sha1. New commits:

​4bfd5e4Merge branch 'u/chapoton/23831' in 8.1.b5
​ac9ff0btrac 23831 better slightly

comment:5 Changed 3 years ago by git

  • Commit changed from ac9ff0bf89bad437e997ea9b28cc671af1bc8481 to 950d6daeec23b1bdfbd77f5e86a105c89998ba84

Branch pushed to git repo; I updated commit sha1. New commits:

​950d6datrac 23831 fix

comment:6 Changed 3 years ago by chapoton

green bot, please review

comment:7 Changed 3 years ago by chapoton

  • Cc tscrim jdemeyer jhpalmieri embray added

ping ?

comment:8 Changed 3 years ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

Looks okay to me.

comment:9 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/23831 to 950d6daeec23b1bdfbd77f5e86a105c89998ba84
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:10 Changed 3 years ago by embray

  • Commit 950d6daeec23b1bdfbd77f5e86a105c89998ba84 deleted

next(iter(self._coord_expression.keys())) this is screaming for a firstkey utility function.

Note: See TracTickets for help on using tickets.