Opened 4 years ago

Closed 4 years ago

#23830 closed enhancement (fixed)

Add SBox Instance: DBlock cipher

Reported by: asante Owned by: asante
Priority: major Milestone: sage-8.1
Component: cryptography Keywords: sbox, crypto
Cc: leo.perrin@… Merged in:
Authors: Friedrich Wiemer Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: 6664059 (Commits, GitHub, GitLab) Commit: 66640591d9f6291987dd4815396b2d1c6689b0b8
Dependencies: #22988 Stopgaps:

Status badges

Description

The list of sboxes does not contain the sbox of the "DBlock" block cipher, see https://link.springer.com/article/10.1007/s11432-014-5219-0.

Change History (10)

comment:1 Changed 4 years ago by asante

  • Dependencies set to 22988

comment:2 Changed 4 years ago by asante

  • Owner changed from (none) to asante

comment:3 Changed 4 years ago by asante

  • Branch set to u/asante/add_sbox_instance__dblock_cipher

comment:4 Changed 4 years ago by asante

  • Commit set to 66640591d9f6291987dd4815396b2d1c6689b0b8
  • Status changed from new to needs_review

Last 10 new commits:

09e1c4aiteritems not py3 compatible -> items
5fd496dMerge branch 'develop' into t/22988/add_sbox_instances
c223d51Merge branch 'develop' into t/22988/add_sbox_instances
43edbb8fixed broken PRESENT reference
dfbd71dfix merge conflict
6b8e8b1the qarma block cipher actually defines three sboxes, one was missing
9b5786aMerge branch 'develop' into t/22988/add_sbox_instances
9515fe6fixes patchbot errors
31aa2dbMerge branch 'u/asante/add_sbox_instances' of git://trac.sagemath.org/sage into t/22988/add_sbox_instances
6664059added sbox instance for DBlock block cipher

comment:5 Changed 4 years ago by asante

I'm not sure, if merging the fixed branch from #22988 is correct. Maybe waiting for the changes to show up in the main branch and then adding the Sbox instance is a better way?

Last edited 4 years ago by asante (previous) (diff)

comment:6 Changed 4 years ago by roed

For the author, you should have your actual name rather than trac username.

comment:7 Changed 4 years ago by roed

Other than that, this looks fine.

A more general issue with the list of sboxes: is there any good way to check whether these sboxes are correct? It would be really easy to have a typo in the definition that nobody caught.

comment:8 Changed 4 years ago by roed

Also, when you list dependencies, use a # symbol so that it creates a link to the other ticket.

comment:9 Changed 4 years ago by roed

  • Authors changed from asante to Friedrich Wiemer
  • Dependencies changed from 22988 to #22988
  • Reviewers set to David Roe
  • Status changed from needs_review to positive_review

comment:10 Changed 4 years ago by vbraun

  • Branch changed from u/asante/add_sbox_instance__dblock_cipher to 66640591d9f6291987dd4815396b2d1c6689b0b8
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.