Opened 5 years ago

Closed 5 years ago

#23804 closed enhancement (fixed)

gap_eval: move libgap_enter() inside sig_on()

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.1
Component: cython Keywords:
Cc: SimonKing, vbraun Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw, Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: e55f34f (Commits, GitHub, GitLab) Commit: e55f34f85b4fede366d770793f9310425cf8c266
Dependencies: Stopgaps:

Status badges

Description

This prevents a crash when accidentally doing libgap_enter() twice.

Change History (6)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/gap_eval__move_libgap_enter___inside_sig_on__

comment:2 Changed 5 years ago by jdemeyer

  • Commit set to d07ac6528166f7dad51f0638900d686179b993d7
  • Status changed from new to needs_review

New commits:

d07ac65gap_eval: move libgap_enter() inside sig_on()

comment:3 Changed 5 years ago by vdelecroix

doctest?

comment:4 Changed 5 years ago by git

  • Commit changed from d07ac6528166f7dad51f0638900d686179b993d7 to e55f34f85b4fede366d770793f9310425cf8c266

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e55f34fgap_eval: move libgap_enter() inside sig_on()

comment:5 Changed 5 years ago by tscrim

  • Reviewers set to Travis Scrimshaw, Vincent Delecroix
  • Status changed from needs_review to positive_review

LGTM.

comment:6 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/gap_eval__move_libgap_enter___inside_sig_on__ to e55f34f85b4fede366d770793f9310425cf8c266
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.