Opened 3 years ago

Closed 3 years ago

#23793 closed defect (fixed)

Doctest: Bug in symbolic GCD computations involving complex I

Reported by: rws Owned by:
Priority: major Milestone: sage-8.1
Component: symbolics Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 638a14b (Commits) Commit: 638a14bdc30f8613b8263271aa7f9a56f908c3d3
Dependencies: #23950 Stopgaps:

Description (last modified by rws)

For example gcd(I-I*x, x^2-1) will raise a runtime error (because I cannot be converted to Singular by Pynac).

Change History (7)

comment:1 Changed 3 years ago by rws

  • Branch set to u/rws/fall_back_to_maxima_with_some_symbolic_gcd_computations

comment:2 Changed 3 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to dd43864a3c7e3cab30f630adcb4c2f45f26b3b67
  • Status changed from new to needs_review

New commits:

​dd4386423793: Fall back to Maxima with some symbolic GCD computations

comment:3 Changed 3 years ago by rws

  • Authors Ralf Stephan deleted
  • Branch u/rws/fall_back_to_maxima_with_some_symbolic_gcd_computations deleted
  • Commit dd43864a3c7e3cab30f630adcb4c2f45f26b3b67 deleted
  • Dependencies set to #23950
  • Description modified (diff)
  • Status changed from needs_review to needs_work
  • Summary changed from Fall back to Maxima with some symbolic GCD computations to Doctest: Bug in symbolic GCD computations involving complex I

Actually this is resolved in Pynac-0.7.12 and just needs a doctest.

comment:4 Changed 3 years ago by rws

  • Branch set to u/rws/23793

comment:5 Changed 3 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to 638a14bdc30f8613b8263271aa7f9a56f908c3d3
  • Status changed from needs_work to needs_review

New commits:

​638a14b23793: Doctest fix for GCD bug

comment:6 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:7 Changed 3 years ago by vbraun

  • Branch changed from u/rws/23793 to 638a14bdc30f8613b8263271aa7f9a56f908c3d3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.