Opened 3 years ago

Closed 3 years ago

#23792 closed defect (fixed)

python3: Fix import time assertion error from ntl_ZZ.__init__

Reported by: embray Owned by:
Priority: major Milestone: sage-8.1
Component: python3 Keywords:
Cc: chapoton Merged in:
Authors: Erik Bray Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: ecb2346 (Commits) Commit: ecb23469a84863be45f97cb004bd658be84d0ef1
Dependencies: Stopgaps:

Description (last modified by embray)

This fixes a crash that occurs sometimes during import of sage.libs.ntl.ntl_ZZ, where ntl_ZZ is passed a random int between 0 and 2^64. This sometimes caused an assertion error due to and unhandled overflow error that could occur by trying to stuff a PyLong into a machine signed long.

Change History (4)

comment:1 Changed 3 years ago by embray

  • Description modified (diff)

I suspect there are probably other cases like this one that I can try to suss out, either as part of this ticket, or just one at a time as we find them...

comment:2 Changed 3 years ago by embray

  • Status changed from new to needs_review

comment:3 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, looks good.

comment:4 Changed 3 years ago by vbraun

  • Branch changed from u/embray/python3/ntl_ZZ_long to ecb23469a84863be45f97cb004bd658be84d0ef1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.