Opened 3 years ago

Closed 2 months ago

#23769 closed defect (fixed)

src/bin/sage-starts should be moved to build/bin

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.1
Component: build Keywords:
Cc: jdemeyer, fbissey, jhpalmieri, embray, dimpase Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 23ffe1d (Commits) Commit: 23ffe1d9ee6d38980a889b49ad838edeb33b0130
Dependencies: Stopgaps:

Description (last modified by mkoeppe)

src/bin/sage-starts uses build/bin/sage-logger (writing into $SAGE_ROOT/logs) and therefore belong to sage-the-distribution rather than sagelib. It should not be installed in $SAGE_LOCAL/bin.

(It could as well be eliminated and merged into build/make/deps (the only place from which it is called); this is where many invocations of build/bin/sage-logger happen and this one could as well, for consistency.)

Part of #21559. See also #21510.

Change History (11)

comment:1 follow-up: Changed 3 years ago by embray

I agree. IIUC the only purpose of this file is to prevent make from building some targets if sage didn't build properly.

comment:2 in reply to: ↑ 1 Changed 3 years ago by jdemeyer

Replying to embray:

IIUC the only purpose of this file is to prevent make from building some targets if sage didn't build properly.

Not quite. I think the purpose is to do a very basic check that Sage actually works. I remember cases in the past where Sage seemed to build fine but doing ./sage would fail. These days, Sage is also used by the build system, so that is less likely. Still, it is good to leave that basic check in place.

comment:3 Changed 3 years ago by mkoeppe

  • Description modified (diff)

comment:4 Changed 3 months ago by mkoeppe

  • Dependencies set to #21559

comment:5 Changed 3 months ago by mkoeppe

  • Branch set to u/mkoeppe/src_bin_sage_starts_should_be_moved_to_build_bin_or_merged_into_build_make_deps

comment:6 Changed 3 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Cc dimpase added
  • Commit set to 23ffe1d9ee6d38980a889b49ad838edeb33b0130
  • Milestone changed from sage-8.2 to sage-9.1
  • Status changed from new to needs_review
  • Summary changed from src/bin/sage-starts should be moved to build/bin or merged into build/make/deps to src/bin/sage-starts should be moved to build/bin

New commits:

23ffe1dMove src/bin/sage-starts to build/bin/

comment:7 Changed 3 months ago by mkoeppe

  • Dependencies #21559 deleted

comment:8 Changed 3 months ago by mkoeppe

  • Description modified (diff)

comment:9 Changed 3 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

lgtm

comment:10 Changed 3 months ago by mkoeppe

Thanks!

comment:11 Changed 2 months ago by vbraun

  • Branch changed from u/mkoeppe/src_bin_sage_starts_should_be_moved_to_build_bin_or_merged_into_build_make_deps to 23ffe1d9ee6d38980a889b49ad838edeb33b0130
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.