Opened 3 years ago
Closed 2 months ago
#23769 closed defect (fixed)
src/bin/sagestarts should be moved to build/bin
Reported by:  mkoeppe  Owned by:  

Priority:  major  Milestone:  sage9.1 
Component:  build  Keywords:  
Cc:  jdemeyer, fbissey, jhpalmieri, embray, dimpase  Merged in:  
Authors:  Matthias Koeppe  Reviewers:  Dima Pasechnik 
Report Upstream:  N/A  Work issues:  
Branch:  23ffe1d (Commits)  Commit:  23ffe1d9ee6d38980a889b49ad838edeb33b0130 
Dependencies:  Stopgaps: 
Description (last modified by )
src/bin/sagestarts
uses build/bin/sagelogger
(writing into $SAGE_ROOT/logs
) and therefore belong to sagethedistribution rather than sagelib. It should not be installed in $SAGE_LOCAL/bin
.
(It could as well be eliminated and merged into build/make/deps
(the only place from which it is called); this is where many invocations of build/bin/sagelogger
happen and this one could as well, for consistency.)
Change History (11)
comment:1 followup: ↓ 2 Changed 3 years ago by
comment:2 in reply to: ↑ 1 Changed 3 years ago by
Replying to embray:
IIUC the only purpose of this file is to prevent make from building some targets if sage didn't build properly.
Not quite. I think the purpose is to do a very basic check that Sage actually works. I remember cases in the past where Sage seemed to build fine but doing ./sage
would fail. These days, Sage is also used by the build system, so that is less likely. Still, it is good to leave that basic check in place.
comment:3 Changed 3 years ago by
 Description modified (diff)
comment:4 Changed 3 months ago by
 Dependencies set to #21559
comment:5 Changed 3 months ago by
 Branch set to u/mkoeppe/src_bin_sage_starts_should_be_moved_to_build_bin_or_merged_into_build_make_deps
comment:6 Changed 3 months ago by
 Cc dimpase added
 Commit set to 23ffe1d9ee6d38980a889b49ad838edeb33b0130
 Milestone changed from sage8.2 to sage9.1
 Status changed from new to needs_review
 Summary changed from src/bin/sagestarts should be moved to build/bin or merged into build/make/deps to src/bin/sagestarts should be moved to build/bin
New commits:
23ffe1d  Move src/bin/sagestarts to build/bin/

comment:7 Changed 3 months ago by
 Dependencies #21559 deleted
comment:8 Changed 3 months ago by
 Description modified (diff)
comment:9 Changed 3 months ago by
 Reviewers set to Dima Pasechnik
 Status changed from needs_review to positive_review
lgtm
comment:10 Changed 3 months ago by
Thanks!
comment:11 Changed 2 months ago by
 Branch changed from u/mkoeppe/src_bin_sage_starts_should_be_moved_to_build_bin_or_merged_into_build_make_deps to 23ffe1d9ee6d38980a889b49ad838edeb33b0130
 Resolution set to fixed
 Status changed from positive_review to closed
I agree. IIUC the only purpose of this file is to prevent make from building some targets if sage didn't build properly.