#23744 closed enhancement (fixed)

Don't use SAGE_CYTHONIZED in sage_include_directories(sources=True)

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.1
Component: build Keywords:
Cc: mkoeppe, embray Merged in:
Authors: Jeroen Demeyer Reviewers: Erik Bray
Report Upstream: N/A Work issues:
Branch: 33746a2 (Commits) Commit: 33746a28f185fbabd69319ca3cde6a7316dff017
Dependencies: Stopgaps:

Description

Currently, SAGE_CYTHONIZED is used by src/sage/env.py to determine some include directories while building Sage.

Since we want to get rid of SAGE_CYTHONIZED (#21535), a first step would be to move this bit to setup.py in order to concentrate all uses of SAGE_CYTHONIZED in one place.

Change History (5)

comment:1 Changed 22 months ago by jdemeyer

  • Branch set to u/jdemeyer/don_t_use_sage_cythonized_in_sage_include_directories_sources_true_

comment:2 Changed 22 months ago by jdemeyer

  • Commit set to 33746a28f185fbabd69319ca3cde6a7316dff017
  • Status changed from new to needs_review

New commits:

33746a2Don't use SAGE_CYTHONIZED in sage_include_directories()

comment:3 follow-up: Changed 22 months ago by embray

  • Reviewers set to Erik Bray
  • Status changed from needs_review to positive_review

I wonder what would happen if we also went ahead and deleted line 110 of sage.env:

_add_variable_or_fallback('SAGE_CYTHONIZED', opj('$SAGE_ROOT', 'src', 'build', 'cythonized'))

That could wait 'til a later change though. Looks good to me otherwise. I agree this is a good first step to removing it entirely.

comment:4 in reply to: ↑ 3 Changed 22 months ago by jdemeyer

Replying to embray:

I wonder what would happen if we also went ahead and deleted line 110 of sage.env:

_add_variable_or_fallback('SAGE_CYTHONIZED', opj('$SAGE_ROOT', 'src', 'build', 'cythonized'))

Some doctests in src/sage_setup use that.

comment:5 Changed 22 months ago by vbraun

  • Branch changed from u/jdemeyer/don_t_use_sage_cythonized_in_sage_include_directories_sources_true_ to 33746a28f185fbabd69319ca3cde6a7316dff017
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.