Changes between Initial Version and Version 1 of Ticket #23732


Ignore:
Timestamp:
Sep 15, 2017, 1:22:34 PM (5 years ago)
Author:
Maarten Derickx
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #23732 – Description

    initial v1  
    1 The title says it all, here is the log.
     1The first error occurs during
     2
     3`make Theora.pdf` which is defined in `$THEORA_SOURCE/doc/spec/Makefile`.
     4Changing the two occurences of `\begin{figure}[Htbp]` to `\begin{figure}[htbp]` in `doc/spec/spec.tex` solves this issue but now it is stuc at a more serious problem:
     5
     6{{{
     7png2theora.c:465:20: warning: implicit declaration of function 'png_sizeof' [-Wimplicit-function-declaration]
     8     3*height*width*png_sizeof(*row_data));
     9                    ^
     10png2theora.c:465:31: warning: 'row_data' may be used uninitialized in this function [-Wmaybe-uninitialized]
     11     3*height*width*png_sizeof(*row_data));
     12                               ^
     13png2theora.c:393:13: note: 'row_data' was declared here
     14   png_bytep row_data;
     15             ^
     16png2theora.c:467:12: warning: 'row_pointers' may be used uninitialized in this function [-Wmaybe-uninitialized]
     17     height*png_sizeof(*row_pointers));
     18            ^
     19png2theora.c:394:14: note: 'row_pointers' was declared here
     20   png_bytep *row_pointers;
     21              ^
     22/bin/bash ../libtool --mode=link gcc -I/users/derickx/sage_test/local/include   -Wall -Wno-parentheses -O3 -fforce-addr -fomit-frame-pointer -finline-functions -funroll-loops   -L/users/derickx/sage_test/local/lib -Wl,-rpath,/users/derickx/sage_test/local/lib  -o png2theora  png2theora-png2theora.o  ../lib/libtheoraenc.la ../lib/libtheoradec.la -L/users/derickx/sage_test/local/lib -logg   -L/users/derickx/sage_test/local/lib -lpng16   -lm
     23libtool: link: gcc -I/users/derickx/sage_test/local/include -Wall -Wno-parentheses -O3 -fforce-addr -fomit-frame-pointer -finline-functions -funroll-loops -Wl,-rpath -Wl,/users/derickx/sage_test/local/lib -o .libs/png2theora png2theora-png2theora.o  -L/users/derickx/sage_test/local/lib ../lib/.libs/libtheoraenc.so ../lib/.libs/libtheoradec.so -logg -lpng16 -lm -Wl,-rpath -Wl,/users/derickx/sage_test/local/lib
     24png2theora-png2theora.o: In function `png_read':
     25png2theora.c:(.text+0x20d): undefined reference to `png_sizeof'
     26png2theora.c:(.text+0x230): undefined reference to `png_sizeof'
     27collect2: error: ld returned 1 exit status
     28Makefile:290: recipe for target 'png2theora' failed
     29make[2]: *** [png2theora] Error 1
     30make[2]: Leaving directory '/users/derickx/sage_test/local/var/tmp/sage/build/libtheora-1.1.1/src/examples'
     31Makefile:291: recipe for target 'all-recursive' failed
     32make[1]: *** [all-recursive] Error 1
     33make[1]: Leaving directory '/users/derickx/sage_test/local/var/tmp/sage/build/libtheora-1.1.1/src'
     34Makefile:205: recipe for target 'all' failed
     35make: *** [all] Error 2
     36Error building libtheora
     37}}}
     38
     39this seems to be because `png_sizeof` was removed from `lib_png` version 1.6.0, see [1] and we ship lib_png 1.6.29.
     40
     41[1] https://github.com/glennrp/libpng/blob/libpng16/CHANGES#L4206
     42
     43this ticket also has attached the full log.