#23731 closed enhancement (fixed)
py3: future division in matrix2
Reported by:  chapoton  Owned by:  

Priority:  major  Milestone:  sage8.1 
Component:  python3  Keywords:  division 
Cc:  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  André Apitzsch, Jeroen Demeyer 
Report Upstream:  N/A  Work issues:  
Branch:  fdf0a68 (Commits, GitHub, GitLab)  Commit:  
Dependencies:  Stopgaps: 
Description
part of #15995
found using the "python 3" tests suggested there
Change History (11)
comment:1 Changed 5 years ago by
Branch:  → u/chapoton/23731 

Commit:  → e65a63e5cc7fda873d9ed34ded4d8c72d3a666f5 
Status:  new → needs_review 
comment:2 Changed 5 years ago by
Summary:  py3: future division in matrix 2 → py3: future division in matrix2 

comment:3 Changed 5 years ago by
Reviewers:  → André Apitzsch 

Status:  needs_review → positive_review 
LGTM.
comment:4 Changed 5 years ago by
Status:  positive_review → needs_work 

I disagree here: why hardcode QQ
? Shouldn't we use self._parent._base
instead?
@@ 1371,7 +1372,7 @@ cdef class Matrix(Matrix1): # now compute the permanental minor of the complement matrix if needed if complement: a = [one]  c1 = 1 + c1 = QQ.one() for k in range(1, mn + 1): c1 = c1*(mk+1)*(nk+1)/k c = c1
comment:5 Changed 5 years ago by
Because for this precise variable, we can stay in QQ. Otherwise, more complicated computations are done.
comment:6 Changed 5 years ago by
Commit:  e65a63e5cc7fda873d9ed34ded4d8c72d3a666f5 → fdf0a68c66108c7d370e5d23bff50d410e2f40a0 

Branch pushed to git repo; I updated commit sha1. New commits:
fdf0a68  trac 23731 try exact division

comment:7 Changed 5 years ago by
So, what about the new commit ? The first makes sense (binomial coefficients) but i would not swear that the second one does make sense too.
New commits:
fdf0a68  trac 23731 try exact division

comment:8 Changed 5 years ago by
Status:  needs_work → needs_review 

comment:9 Changed 5 years ago by
Reviewers:  André Apitzsch → André Apitzsch, Jeroen Demeyer 

Status:  needs_review → positive_review 
comment:10 Changed 5 years ago by
Branch:  u/chapoton/23731 → fdf0a68c66108c7d370e5d23bff50d410e2f40a0 

Resolution:  → fixed 
Status:  positive_review → closed 
comment:11 Changed 5 years ago by
Commit:  fdf0a68c66108c7d370e5d23bff50d410e2f40a0 

Keywords:  division added 
Note: See
TracTickets for help on using
tickets.
New commits:
py3: future division in matrix2