Opened 5 years ago

Closed 5 years ago

#23721 closed defect (fixed)

copy of libgap object is broken

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-8.1
Component: interfaces Keywords:
Cc: Merged in:
Authors: Vincent Delecroix Reviewers: Aly Deines
Report Upstream: N/A Work issues:
Branch: a087066 (Commits, GitHub, GitLab) Commit: a087066fdf94cc9a0405807705b8867d538b5980
Dependencies: Stopgaps:

Status badges

Description

sage: l = libgap([0,1])
sage: l
sage: copy(l)
NULL

Change History (5)

comment:1 Changed 5 years ago by vdelecroix

  • Authors set to Vincent Delecroix
  • Branch set to u/vdelecroix/23721
  • Commit set to 3060ae6adc5470b15613b29a15a546e04020bb4e
  • Status changed from new to needs_review

New commits:

457d2fb23704: getitem/setitem for libgap elements
4dc210b23704: forgot to set j appropriately!
c3241d623704: "multi-indices "multi indices" "multiindices"
3060ae623721: fix __copy__ on GapElement

comment:2 Changed 5 years ago by git

  • Commit changed from 3060ae6adc5470b15613b29a15a546e04020bb4e to 7cfd2856f680c794e462df92e05ddcbf1c05b67a

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

7cfd28523721: fix __copy__ on GapElement

comment:3 Changed 5 years ago by git

  • Commit changed from 7cfd2856f680c794e462df92e05ddcbf1c05b67a to a087066fdf94cc9a0405807705b8867d538b5980

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a08706623721: __copy__/__deepcopy__ on GapElement

comment:4 Changed 5 years ago by aly.deines

  • Reviewers set to Aly Deines
  • Status changed from needs_review to positive_review

Looks good.

comment:5 Changed 5 years ago by vbraun

  • Branch changed from u/vdelecroix/23721 to a087066fdf94cc9a0405807705b8867d538b5980
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.