Opened 12 months ago

Last modified 6 months ago

#23720 needs_work enhancement

Plotting Mandelbrot Set for General Polynomials

Reported by: bbarros Owned by:
Priority: minor Milestone: sage-8.1
Component: dynamics Keywords: complexdynamics, gsoc2017
Cc: bhutz, atowsley Merged in:
Authors: Ben Barros Reviewers: Ben Hutz
Report Upstream: N/A Work issues:
Branch: u/bbarros/23720 (Commits) Commit: afbc43853d508da64b588be17df828d5d2106775
Dependencies: Stopgaps:

Description

This ticket is the part of a series of tickets that I have opened this summer in an effort to improve the functionality for complex dynamics in Sage. I have enhanced the mandelbrot_plot() function to support general polynomial functions. The map z^2 + c is still hardcoded so the function will not lose any speed for the z^2 + c case. For more information on my Google Summer of Code Project you can visit the following link: [​https://benbarros.wordpress.com/]

Change History (6)

comment:1 Changed 12 months ago by bbarros

  • Branch set to u/bbarros/23720

comment:2 Changed 12 months ago by bbarros

  • Commit set to 6443ab7fe3f5649992e90c0e9a7a34b4c5514a73
  • Status changed from new to needs_review

New commits:

0f22b6f23720: Added mandelbrot_plot support for general polynomials
6443ab7Merge branch 'master' into 23720

comment:3 Changed 12 months ago by git

  • Commit changed from 6443ab7fe3f5649992e90c0e9a7a34b4c5514a73 to c141f070ac00807dd11e098f3c4a8f2e9c8bd028

Branch pushed to git repo; I updated commit sha1. New commits:

c141f0723720: Fixed bug in external_ray function

comment:4 Changed 12 months ago by kdilks

Patchbot says the external_ray and mandelbrot_plot methods give "WARNING: Bullet list ends without a blank line; unexpected unindent." when building the documentation.

comment:5 Changed 12 months ago by bhutz

  • Reviewers set to Ben Hutz
  • Status changed from needs_review to needs_work

In addition to the docbuild error here are a couple more:

  • You should have a doctest that utilizes the symbolic critical point code

There is some trouble with the initial parsing. When you say P.base() do you P.base_ring()? Will you allow function fields or rational functions in the parameter? Whatever you decide it needs to be documented in mandelbrot_plot().

  • f = z^2 +1/c - weird error
  • the following does not work and I think it should.
    R.<c> = CC[]
    S.<z> = R[]
    f = z^2 +c
    mandelbrot_plot(f)
    
  • The following has a uninformative error
R.<z,x,c> = CC[]
f = z^2 + c

comment:6 Changed 6 months ago by git

  • Commit changed from c141f070ac00807dd11e098f3c4a8f2e9c8bd028 to afbc43853d508da64b588be17df828d5d2106775

Branch pushed to git repo; I updated commit sha1. New commits:

4755789Merge branch 'master' into 23720
afbc43823720: Bug, documentation fixes
Note: See TracTickets for help on using tickets.