Opened 5 years ago

Closed 4 years ago

#23714 closed enhancement (fixed)

GAP matrices

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-8.2
Component: linear algebra Keywords:
Cc: Merged in:
Authors: Vincent Delecroix Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: a66e1d7 (Commits, GitHub, GitLab) Commit: a66e1d70ae87b9bbdb0b86d79e553747c365c176
Dependencies: Stopgaps:

Status badges

Description (last modified by vdelecroix)

Add a new class Matrix_gap for matrices with a libgap backend.

Resources

Change History (9)

comment:1 Changed 5 years ago by vdelecroix

  • Authors set to Vincent Delecroix
  • Dependencies set to #23706
  • Description modified (diff)
  • Summary changed from more GAP linear algebra in Sage to GAP matrices

comment:2 Changed 5 years ago by vdelecroix

  • Branch set to u/vdelecroix/23714
  • Commit set to 09e6f28a5f234ed9f12f0e582d1b30bcaff35b41
  • Status changed from new to needs_review

New commits:

4efbf5123706: allow to choose matrix mplementation
09e6f2823714: Matrix_gap

comment:3 Changed 4 years ago by git

  • Commit changed from 09e6f28a5f234ed9f12f0e582d1b30bcaff35b41 to ac406955c714a58efe4b6a4c4a6c425769e6c987

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

20170df23714: Matrix_gap
ac4069523714: gap matrices over finite fields

comment:4 Changed 4 years ago by vdelecroix

  • Dependencies #23706 deleted
  • Milestone changed from sage-8.1 to sage-8.2

rebased on beta4

comment:5 Changed 4 years ago by tscrim

One little thing. I think it would look much better if you just cimport Matrix rather than the whole sage.structure.element. Otherwise LGTM.

comment:6 Changed 4 years ago by git

  • Commit changed from ac406955c714a58efe4b6a4c4a6c425769e6c987 to a66e1d70ae87b9bbdb0b86d79e553747c365c176

Branch pushed to git repo; I updated commit sha1. New commits:

aaf8be723714: simpler imports
a66e1d723714: more doctests

comment:7 Changed 4 years ago by vdelecroix

Good suggestion. Done. (I also added a doctest for UCF).

comment:8 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Looks good.

comment:9 Changed 4 years ago by vbraun

  • Branch changed from u/vdelecroix/23714 to a66e1d70ae87b9bbdb0b86d79e553747c365c176
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.