Opened 5 years ago

Last modified 4 years ago

#23713 closed defect

Support SAGE_NUM_THREADS for parallellism — at Version 5

Reported by: jdemeyer Owned by:
Priority: blocker Milestone: sage-8.1
Component: doctest framework Keywords:
Cc: hivert Merged in:
Authors: Jeroen Demeyer Reviewers:
Report Upstream: N/A Work issues:
Branch: u/jdemeyer/support_sage_num_threads_parallel_in_parallel_map_reduce (Commits, GitHub, GitLab) Commit: 282c95423512fe2c14481ab83ab29cfa4c64061f
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

There are several independent implementations in Sage to determine the number of threads or processors for a parallel computation. Instead, these should be one way to do that and it should support the environment variable SAGE_NUM_THREADS, which is precisely meant for that.

On top of that, doctests should never use too many threads. So we set SAGE_NUM_THREADS=2 while doctesting, analogous to #23892.

This fixes doctests in:

  • parallel map/reduce
  • cryptominisat

Change History (5)

comment:1 Changed 5 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from Parallel map/reduce doctests fail on machine with lots of CPUs to Support SAGE_NUM_THREADS_PARALLEL in parallel map/reduce

comment:2 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/support_sage_num_threads_parallel_in_parallel_map_reduce

comment:3 Changed 5 years ago by jdemeyer

  • Commit set to 282c95423512fe2c14481ab83ab29cfa4c64061f
  • Status changed from new to needs_review

New commits:

282c954Support SAGE_NUM_THREADS_PARALLEL in parallel map/reduce

comment:4 Changed 5 years ago by jdemeyer

  • Component changed from doctest coverage to doctest framework
  • Description modified (diff)
  • Priority changed from critical to blocker
  • Status changed from needs_review to needs_work
  • Summary changed from Support SAGE_NUM_THREADS_PARALLEL in parallel map/reduce to Support SAGE_NUM_THREADS for parallellism

comment:5 Changed 5 years ago by jdemeyer

  • Description modified (diff)
Note: See TracTickets for help on using tickets.