#23705 closed enhancement (fixed)
Doctests from Judson's Abstract Algebra textbook
Reported by:  rbeezer  Owned by:  

Priority:  minor  Milestone:  sage8.1 
Component:  doctest coverage  Keywords:  days88 
Cc:  Merged in:  
Authors:  Rob Beezer  Reviewers:  Vincent Delecroix 
Report Upstream:  N/A  Work issues:  
Branch:  5e9dff8 (Commits, GitHub, GitLab)  Commit:  
Dependencies:  Stopgaps: 
Description
Add roughly 700 doctests from the examples in this undergraduate text. Total CPU time is roughly 7.5 seconds on an ordinary laptop.
Change History (17)
comment:1 Changed 5 years ago by
 Branch set to /u/rbeezer/t/23705/doctestabstractalgebra
comment:2 Changed 5 years ago by
 Branch changed from /u/rbeezer/t/23705/doctestabstractalgebra to u/rbeezer/t/23705/doctestabstractalgebra
comment:3 Changed 5 years ago by
 Commit set to 70b170b6cef509f4b8d73bb05fcb6f1de6adc044
comment:4 Changed 5 years ago by
 Keywords sd88 added
comment:5 Changed 5 years ago by
 Status changed from new to needs_review
comment:6 Changed 5 years ago by
A small patchbot complaint (I have none): the print statements in the documentation should now use python 3 syntax. The following is (almost) wrong
sage: print gap.help('SymmetricGroup', pager=False) # not tested
I agree that this is not tested but the patchbot is not smart enough.
comment:7 Changed 5 years ago by
 Keywords days88 added; sd88 removed
 Reviewers set to Vincent Delecroix
comment:8 Changed 5 years ago by
 Commit changed from 70b170b6cef509f4b8d73bb05fcb6f1de6adc044 to 5e9dff8a27162a92444bdf16814254b2be02837d
Branch pushed to git repo; I updated commit sha1. New commits:
5e9dff8  Rewrite untested doctest with correct Python3 syntax

comment:9 Changed 5 years ago by
Thanks, Vincent. I caught 4 other oldstyle print statements, but missed the untested one. Thanhks very much for looking at this one.
comment:10 Changed 5 years ago by
 Status changed from needs_review to positive_review
Now patchbot is very happy ;)
comment:11 Changed 5 years ago by
Merci, Vincent. The patchbot is working much better than it used to! Nice to meet you this past week at SD88.
comment:12 Changed 5 years ago by
 Branch changed from u/rbeezer/t/23705/doctestabstractalgebra to 5e9dff8a27162a92444bdf16814254b2be02837d
 Resolution set to fixed
 Status changed from positive_review to closed
comment:13 Changed 5 years ago by
 Commit 5e9dff8a27162a92444bdf16814254b2be02837d deleted
Hi,
This is giving doctest failures at https://patchbot.sagemath.org/log/23927/Ubuntu/14.04/i686/3.13.095generic/arando/20170925%2021:41:12?short the answers seem to be mathematically correct, and the failures seem to stem from output of nondeterministic algorithms being tested.
comment:14 Changed 5 years ago by
This is now #23930
comment:15 Changed 5 years ago by
Also trouble in #23544.
comment:16 Changed 5 years ago by
Just a question: I noticed that the tests are written as .py
files, but they don't contain any Python code at all. So why was the choice made for .py
as format, as opposed to .rst
for example?
comment:17 Changed 5 years ago by
(I tried to reply by email while traveling  I guess that didn't work.)
There was no particular reason for using *.py
and I'd be open to suggestions for better alternatives.
Branch pushed to git repo; I updated commit sha1. New commits:
Add doctests for Judson's Abstract Algebra textbook