Opened 4 years ago

Closed 4 years ago

#23701 closed enhancement (fixed)

new standard package libatomic_ops

Reported by: dimpase Owned by:
Priority: major Milestone: sage-8.2
Component: packages: standard Keywords:
Cc: fbissey Merged in:
Authors: Dima Pasechnik, Erik Bray Reviewers: Erik Bray, Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 18813a2 (Commits, GitHub, GitLab) Commit: 18813a24286e40c935400688e514a989fe5e20a6
Dependencies: Stopgaps:

Status badges

Description (last modified by dimpase)

This is needed for the gc update on #23700, see GC website for details.

The package is C headers and two small static libraries.

The tarball is here: https://github.com/ivmai/libatomic_ops/releases/download/v7.6.2/libatomic_ops-7.6.2.tar.gz

Change History (24)

comment:1 Changed 4 years ago by dimpase

  • Authors set to Dima Pasechnik
  • Branch set to u/dimpase/libatomic_ops
  • Cc fbissey added
  • Commit set to 7d09a89df33436f32667b197112687c297e27bcd
  • Status changed from new to needs_review

New commits:

7d09a89libatomic_ops added as standard pkg

comment:2 Changed 4 years ago by fbissey

Why 7.4.4 and not 7.6.0 matching boehm-gc? Ok, that's because the download web[age doesn't point to the new github repos: https://github.com/ivmai/libatomic_ops/releases https://github.com/ivmai/bdwgc/releases

comment:3 Changed 4 years ago by dimpase

Right, so should we stick to what they tag as "Latest release", i.e. 7.4.4 for gc and 7.4.6 for libatomic_ops?

comment:4 Changed 4 years ago by fbissey

I am ok with that and at least that's what I have here, so I can say personally that it has some testing on linux. 7.6.0 should at least all build otherwise I would have had complaints on gentoo's bugzilla (a guy called Jurgen Rose is building everything in ~amd64 - unstable in debian parlance - I usually know quite quickly if something breaks sage building).

comment:5 Changed 4 years ago by git

  • Commit changed from 7d09a89df33436f32667b197112687c297e27bcd to 8166e2103f9a9c92cf72fd90ccc192352b859fb4

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8166e21libatomic_ops 7.6.4 added as standard pkg

comment:6 Changed 4 years ago by dimpase

  • Description modified (diff)

comment:7 Changed 4 years ago by git

  • Commit changed from 8166e2103f9a9c92cf72fd90ccc192352b859fb4 to 4d5bbd03ee8762042cde99740e821169c3d3a579

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4d5bbd0libatomic_ops 7.4.6 added as standard pkg

comment:8 Changed 4 years ago by embray

  • Status changed from needs_review to needs_work

These flags

+CONFIGURE_FLAGS="--enable-large-config"
+if [ "$UNAME" = "CYGWIN" ]; then
+    # See https://trac.sagemath.org/ticket/22694
+    CONFIGURE_FLAGS="$CONFIGURE_FLAGS --enable-threads=posix --enable-handle-fork"
+fi

are for libgc and are not applicable to libatomic_ops

comment:9 Changed 4 years ago by git

  • Commit changed from 4d5bbd03ee8762042cde99740e821169c3d3a579 to 5c5d8f6c84a0a0b00c8c924a881adc20051d6528

Branch pushed to git repo; I updated commit sha1. New commits:

7b0f626Merge branch 'u/dimpase/libatomic_ops' of trac.sagemath.org:sage into laup
5c5d8f6remove meaningless flags

comment:10 Changed 4 years ago by dimpase

  • Status changed from needs_work to needs_review

oops, sorry, fixed now.

comment:11 Changed 4 years ago by embray

-CONFIGURE_FLAGS="--enable-large-config"
-if [ "$UNAME" = "CYGWIN" ]; then
-    # See https://trac.sagemath.org/ticket/22694
-    CONFIGURE_FLAGS="$CONFIGURE_FLAGS --enable-threads=posix --enable-handle-fork"
-fi
-
 ./configure --prefix="$SAGE_LOCAL" --libdir="$SAGE_LOCAL/lib" $CONFIGURE_FLAGS

Now $CONFIGURE_FLAGS is undefined and not used so you could remove that too.

Also, I have another change I need to propose but I'm still investigating a bit...

comment:12 Changed 4 years ago by dimpase

We should go for 7.6.2, released last month https://github.com/ivmai/libatomic_ops/releases/tag/v7.6.2 (to match the corresponding GC release) I will update accordingly.

comment:13 Changed 4 years ago by git

  • Commit changed from 5c5d8f6c84a0a0b00c8c924a881adc20051d6528 to a024f8d8183ff46dee1b34a73887885bb206dda9

Branch pushed to git repo; I updated commit sha1. New commits:

54e1da7Merge branch 'develop' into libatomic_ops
a024f8d7.6.2 is the current version

comment:14 Changed 4 years ago by dimpase

  • Description modified (diff)
  • Milestone changed from sage-8.1 to sage-8.2

comment:15 Changed 4 years ago by embray

I have some slight changes to this

1) To get it compatible with #23701 on Cygwin

2) To update it to use sage-dist-helpers à la #24025

Do you mind if I replace this with my branch? If it works then positive review from me (with apologies for the long delay)

Last edited 4 years ago by embray (previous) (diff)

comment:16 Changed 4 years ago by dimpase

sure, please go ahead.

comment:17 Changed 4 years ago by embray

  • Authors changed from Dima Pasechnik to Dima Pasechnik, Erik Bray
  • Branch changed from u/dimpase/libatomic_ops to public/ticket-23701
  • Commit changed from a024f8d8183ff46dee1b34a73887885bb206dda9 to 18813a24286e40c935400688e514a989fe5e20a6
  • Reviewers set to Erik Bray

I guess somebody should review my changes as well.


New commits:

7135b2fOn Cygwin install libatomic_ops as a shared lib only; this is inline with what the official Cygwin package does
18813a2Convert libatomic_ops to use sage-dist-helpers

comment:18 Changed 4 years ago by dimpase

Could we do reviewing of this ticket and #23700 in one go, as this is the dependency of #23700 and only #23700?

comment:19 Changed 4 years ago by jdemeyer

  • Status changed from needs_review to needs_work

Could you remove the SAGE64 stuff, see #23733.

comment:20 Changed 4 years ago by dimpase

  • Status changed from needs_work to needs_review

Well, eventually, yes, we will get rid of SAGE64, but #23733 isn't in great shape at the moment. Thus I set this back to needs review.

comment:21 Changed 4 years ago by embray

It does seem a bit orthogonal.

comment:22 Changed 4 years ago by jdemeyer

  • Status changed from needs_review to needs_work

Instead of CONFIGURE_FLAGS, most packages use a variable name of the form {PACKAGENAME}_CONFIGURE. So I suggest to use LIBATOMIC_OPS_CONFIGURE for this.

And please remove the SAGE64 stuff. That hasn't been used in years.

comment:23 Changed 4 years ago by dimpase

  • Reviewers changed from Erik Bray to Erik Bray, Dima Pasechnik
  • Status changed from needs_work to positive_review

While SAGE64 removal waits, let us get this in.

comment:24 Changed 4 years ago by vbraun

  • Branch changed from public/ticket-23701 to 18813a24286e40c935400688e514a989fe5e20a6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.