Opened 4 years ago

Closed 4 years ago

#23695 closed enhancement (fixed)

Bypass Maxima with any complex I arithmetic

Reported by: rws Owned by:
Priority: major Milestone: sage-8.1
Component: performance Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 41f0e9d (Commits, GitHub, GitLab) Commit: 41f0e9dd70c9d0bc8138f703cbd8f020e107ed8e
Dependencies: Stopgaps:

Status badges

Description (last modified by rws)

Arithmetic with complex I may involve symbolic equation solving using Maxima because QQbar calls minpoly.roots every time, which uses Maxima's solve for symbolic output. Special code in sage/rings/polynomial/polynomial_element.pyx reduces time 100x for the first call (Maxima startup) and 2x for any following.

Change History (10)

comment:1 Changed 4 years ago by rws

  • Branch set to u/rws/bypass_maxima_with_any_complex_i_arithmetic

comment:2 Changed 4 years ago by rws

  • Commit set to 54d2414a4e9d88524427a80ddc68d9b913e1978f
  • Description modified (diff)

There is a doctest fail involving oo.


New commits:

54d241423695: Bypass Maxima with any complex I arithmetic

comment:3 Changed 4 years ago by rws

  • Branch u/rws/bypass_maxima_with_any_complex_i_arithmetic deleted
  • Commit 54d2414a4e9d88524427a80ddc68d9b913e1978f deleted

comment:4 Changed 4 years ago by rws

  • Branch set to u/rws/23695

comment:5 Changed 4 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to fd88d39086076d7e5d1160c13a5532bfda74ed94
  • Status changed from new to needs_review

New commits:

fd88d3923695: Bypass Maxima with degree 2 roots

comment:6 Changed 4 years ago by tscrim

The patchbot is reporting some failures. They are all equivalent forms, so I think you just need to update the output.

comment:7 Changed 4 years ago by git

  • Commit changed from fd88d39086076d7e5d1160c13a5532bfda74ed94 to 41f0e9dd70c9d0bc8138f703cbd8f020e107ed8e

Branch pushed to git repo; I updated commit sha1. New commits:

41f0e9d23695: doctest fixes

comment:8 Changed 4 years ago by rws

Patchbot passes now.

comment:9 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

comment:10 Changed 4 years ago by vbraun

  • Branch changed from u/rws/23695 to 41f0e9dd70c9d0bc8138f703cbd8f020e107ed8e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.