Opened 4 years ago

Closed 4 years ago

#23689 closed enhancement (fixed)

remove deprecated keyword "hold" in matplotlib

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-8.1
Component: porting Keywords:
Cc: fbissey Merged in:
Authors: Frédéric Chapoton Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: e0a0462 (Commits, GitHub, GitLab) Commit: e0a0462f01dbf4c7dd412ff2c2c0a90033953c4c
Dependencies: Stopgaps:

Status badges

Description

to help for #23687

Change History (6)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/23689
  • Commit set to e0a0462f01dbf4c7dd412ff2c2c0a90033953c4c
  • Status changed from new to needs_review

New commits:

e0a0462removing hold keyword (deprecated in matplotlib 2.0)

comment:2 Changed 4 years ago by dimpase

  • Status changed from needs_review to positive_review

Looks good to me.

comment:3 Changed 4 years ago by dimpase

  • Cc fbissey added

The followup: matplotlib update: #23696

comment:4 Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work

Reviewer name missing

comment:5 Changed 4 years ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_work to positive_review

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/23689 to e0a0462f01dbf4c7dd412ff2c2c0a90033953c4c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.