Opened 4 years ago

Closed 4 years ago

#23685 closed defect (fixed)

Minkowski -> minkowski (polyhedra methods)

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-8.2
Component: geometry Keywords:
Cc: mkoeppe, jipilab, moritz Merged in:
Authors: Frédéric Chapoton Reviewers: Jean-Philippe Labbé
Report Upstream: N/A Work issues:
Branch: 6ec20fe (Commits, GitHub, GitLab) Commit: 6ec20fe6b061515e42ed94a165d81a0407c7e492
Dependencies: Stopgaps:

Status badges

Description

Method names should be lower case... make lower case transition with deprecation for

  • Minkowski_sum
  • Minkowski_difference
  • is_Minkowski_summand
  • Minkowski_decompositions

Change History (5)

comment:1 Changed 4 years ago by chapoton

  • Authors set to Frédéric Chapoton
  • Branch set to u/chapoton/23685
  • Commit set to 6ec20fe6b061515e42ed94a165d81a0407c7e492
  • Status changed from new to needs_review

done

New commits:

​6ec20fetrac 23685 deprecate methods with capital Minkowski >> minkowski

comment:2 Changed 4 years ago by chapoton

  • Milestone changed from sage-8.1 to sage-8.2

comment:3 Changed 4 years ago by chapoton

green bot, please review

comment:4 Changed 4 years ago by jipilab

  • Reviewers set to Jean-Philippe Labbé
  • Status changed from needs_review to positive_review

Looks good to go to me.

comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/23685 to 6ec20fe6b061515e42ed94a165d81a0407c7e492
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.