Opened 4 years ago
Closed 4 years ago
#23644 closed defect (fixed)
Stopgap for conversion of polynomials over fraction fields to Singular
Reported by:  saraedum  Owned by:  

Priority:  blocker  Milestone:  sage8.1 
Component:  interfaces  Keywords:  
Cc:  Merged in:  
Authors:  Julian Rüth, Maarten Derickx  Reviewers:  David Roe 
Report Upstream:  N/A  Work issues:  
Branch:  c410c89 (Commits, GitHub, GitLab)  Commit:  c410c89d15b4b72ad841a2c7bdf385f359faf498 
Dependencies:  Stopgaps: 
Description
Stopgap for #17696.
Change History (9)
comment:1 Changed 4 years ago by
 Branch set to u/saraedum/stopgap_for_conversion_of_polynomials_over_fraction_fields_to_singular
comment:2 Changed 4 years ago by
 Branch u/saraedum/stopgap_for_conversion_of_polynomials_over_fraction_fields_to_singular deleted
 Status changed from new to needs_review
comment:3 Changed 4 years ago by
 Branch set to u/saraedum/stopgap_for_conversion_of_polynomials_over_fraction_fields_to_singular
 Commit set to f6bb1145a545a98404f8b35de03f30add0c9d4a6
New commits:
f6bb114  Stopgap warning for disappearing denominators when converting to Singular

comment:4 Changed 4 years ago by
 Reviewers set to David Roe
 Status changed from needs_review to needs_work
The ticket number shown should be 17696 rather than 23644. Other than that, looks good.
comment:5 Changed 4 years ago by
 Branch changed from u/saraedum/stopgap_for_conversion_of_polynomials_over_fraction_fields_to_singular to u/mderickx/23644
 Commit changed from f6bb1145a545a98404f8b35de03f30add0c9d4a6 to c410c89d15b4b72ad841a2c7bdf385f359faf498
 Status changed from needs_work to needs_review
comment:6 Changed 4 years ago by
p.s. Julian, would you please use shorter branch names next time, to long branch names render really awkward on trac.
comment:7 Changed 4 years ago by
 Status changed from needs_review to positive_review
Looks good.
As for the branch name, the default name comes from the title of the ticket, so you can blame git trac
.
comment:8 Changed 4 years ago by
Ok I blamed gittrac
at GitHub issue 27
comment:9 Changed 4 years ago by
 Branch changed from u/mderickx/23644 to c410c89d15b4b72ad841a2c7bdf385f359faf498
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Now it prints: