Opened 5 years ago

Closed 5 years ago

#23620 closed defect (fixed)

gcd has wrong parent

Reported by: saraedum Owned by:
Priority: major Milestone: sage-8.1
Component: padics Keywords: gcd
Cc: Merged in:
Authors: Julian Rüth Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: ada3927 (Commits, GitHub, GitLab) Commit: ada3927e391c2f2945cc0a6269ac859ab85735ea
Dependencies: Stopgaps:

Status badges

Description (last modified by saraedum)

Currently, the parent of a gcd might be wrong when the gcd of polynomials is just the gcd of its contents: 

sage: R.<x> = ZpFM(2)[]
sage: f = 2*x + 2
sage: g = 4*x + 2
sage: f.gcd(g).parent() is R
False # parent is ZpFM(2)

Change History (4)

comment:1 Changed 5 years ago by saraedum

  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by saraedum

  • Branch set to u/saraedum/gcd_has_wrong_parent

comment:3 Changed 5 years ago by roed

  • Commit set to ada3927e391c2f2945cc0a6269ac859ab85735ea
  • Reviewers set to David Roe
  • Status changed from needs_review to positive_review

Looks good.

New commits:

​ada3927gcd(f,g) has the same parent as f and g

comment:4 Changed 5 years ago by vbraun

  • Branch changed from u/saraedum/gcd_has_wrong_parent to ada3927e391c2f2945cc0a6269ac859ab85735ea
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.