Opened 5 years ago

Closed 5 years ago

#23616 closed defect (fixed)

fmpz_mat_to_mpz_array ignores exceptions

Reported by: jdemeyer Owned by:
Priority: minor Milestone: sage-8.1
Component: cython Keywords:
Cc: vdelecroix, cpernet Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 4898e3b (Commits, GitHub, GitLab) Commit: 4898e3b04045e495e8252fbcca83275b66e5b2c0
Dependencies: Stopgaps:

Status badges

Description

I saw this happen once: 

Traceback (most recent call last):
  File "memory.pxd", line 117, in cysignals.memory.check_malloc (build/cythonized/sage/matrix/matrix_integer_dense.c:51851)
MemoryError: failed to allocate 1564152576 bytes
Exception MemoryError: MemoryError('failed to allocate 1564152576 bytes',) in 'sage.matrix.matrix_integer_dense.fmpz_mat_to_mpz_array' ignored

Change History (5)

comment:1 Changed 5 years ago by jdemeyer

Cc: vdelecroix cpernet added

comment:2 Changed 5 years ago by jdemeyer

Branch: → u/jdemeyer/fmpz_mat_to_mpz_array_ignores_exceptions

comment:3 Changed 5 years ago by jdemeyer

Commit: → 4898e3b04045e495e8252fbcca83275b66e5b2c0
Status: new → needs_review

New commits:

​4898e3bAllow exceptions in fmpz_mat_to_mpz_array

comment:4 Changed 5 years ago by tscrim

Reviewers: → Travis Scrimshaw
Status: needs_review → positive_review

All of the changes make sense.

comment:5 Changed 5 years ago by vbraun

Branch: u/jdemeyer/fmpz_mat_to_mpz_array_ignores_exceptions → 4898e3b04045e495e8252fbcca83275b66e5b2c0
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.