Opened 5 years ago

Last modified 2 years ago

#23613 needs_work defect

Doctest failure if $PYTHONPATH is set

Reported by: mderickx Owned by:
Priority: minor Milestone: sage-8.1
Component: scripts Keywords:
Cc: Merged in:
Authors: Maarten Derickx Reviewers:
Report Upstream: N/A Work issues:
Branch: u/mderickx/23613 (Commits, GitHub, GitLab) Commit: db40f2285f3a7efa6b493d41a96ec495bd6c421a
Dependencies: Stopgaps:

Status badges

Description 

./sage -t src/sage/tests/cmdline.py
Running doctests with ID 2017-08-11-19-16-39-40d33b31.
Git branch: test_external_package
Using --optional=ccache,mpir,openssl,python2,sage
Doctesting 1 file.
sage -t --warn-long 45.3 src/sage/tests/cmdline.py
**********************************************************************
File "src/sage/tests/cmdline.py", line 208, in sage.tests.cmdline.test_executable
Failed example:
    print(out)
Expected:
    Found local metadata for sqlite-...
    = SQLite =
    ...
    SQLite is a software library that implements a self-contained,
    serverless, zero-configuration, transactional SQL database engine.
    ...
Got:
    Cleaning up PYTHONPATH:
      Old: ":/Users/mderickx/code:/Users/mderickx/code/lmfdb"
      New: "/Users/mderickx/code:/Users/mderickx/code/lmfdb"
    Found local metadata for sqlite-autoconf-3170000
    = SQLite =
    <BLANKLINE>
    == Description ==
    <BLANKLINE>
    SQLite is a software library that implements a self-contained,
    serverless, zero-configuration, transactional SQL database engine.
    <BLANKLINE>
    == License ==
    <BLANKLINE>

Change History (9)

comment:1 Changed 5 years ago by mderickx

I thought this would be a quick fix, namely just add 

...

to the doctests in order to account for the error. But it seems that the meaning of ... is overloaded in doctests, and that the doctest framework sees ... as an input continuation marker like ....:.

comment:2 Changed 5 years ago by mderickx

  • Branch set to u/mderickx/trac_23613
  • Commit set to d1222c83ae202618c93c2a9892706285e6f4cdde
  • Status changed from new to needs_review

New commits:

​d1222c8Fix doctest that fails when $PYTHONPATH is set

comment:3 Changed 5 years ago by mderickx

  • Authors set to Maarten Derickx

comment:4 Changed 5 years ago by mderickx

  • Status changed from needs_review to needs_work

The workaround apparently doesn't work in combination with -tp

comment:5 Changed 5 years ago by mderickx

  • Branch changed from u/mderickx/trac_23613 to u/mderickx/23613
  • Commit changed from d1222c83ae202618c93c2a9892706285e6f4cdde to db40f2285f3a7efa6b493d41a96ec495bd6c421a

New commits:

​db40f22Fix doctest that fails when $PYTHONPATH is set: trac #23613

comment:6 Changed 5 years ago by mderickx

  • Status changed from needs_work to needs_review

comment:7 Changed 5 years ago by mderickx

  • Keywords beginner added

comment:8 Changed 3 years ago by klui

  • Status changed from needs_review to needs_work

Merge conflict with #27635

comment:9 Changed 2 years ago by gh-DaveWitteMorris

  • Keywords beginner removed

Removing the "beginner" tag from old tickets. Some could be returned to beginner-friendly status by adding a comment about what needs to be done. Some others might be easy for an experienced developer to finish.

Note: See TracTickets for help on using tickets.