Opened 5 years ago
Closed 5 years ago
#23612 closed defect (fixed)
Include !python3 in default value for SAGE_CHECK_PACKAGES
Reported by: | jhpalmieri | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-8.1 |
Component: | packages: standard | Keywords: | |
Cc: | Merged in: | ||
Authors: | John Palmieri | Reviewers: | Jeroen Demeyer |
Report Upstream: | N/A | Work issues: | |
Branch: | adf07e5 (Commits, GitHub, GitLab) | Commit: | adf07e5ef670bb28ccdc87efb8f3049753bde415 |
Dependencies: | Stopgaps: |
Description
SAGE_CHECK_PACKAGES
has a default setting of !python2
since that package does not pass its test suite. The same is true for Python 3, so we should include !python3
in the default value, too.
Change History (8)
comment:1 Changed 5 years ago by
- Branch set to u/jhpalmieri/develop
comment:2 Changed 5 years ago by
- Commit set to c5301516a0342751d5e40e5a893d606ba203b838
comment:3 Changed 5 years ago by
- Status changed from new to needs_review
comment:4 follow-up: ↓ 7 Changed 5 years ago by
- Reviewers set to Jeroen Demeyer
- Status changed from needs_review to needs_work
This should be changed :-)
As of this writing (April 2013, Sage 5.8)
So positive_review modulo that.
comment:5 Changed 5 years ago by
- Commit changed from c5301516a0342751d5e40e5a893d606ba203b838 to adf07e5ef670bb28ccdc87efb8f3049753bde415
Branch pushed to git repo; I updated commit sha1. New commits:
adf07e5 | trac 23612: fix Sage version
|
comment:6 Changed 5 years ago by
- Status changed from needs_work to positive_review
comment:7 in reply to: ↑ 4 Changed 5 years ago by
Replying to jdemeyer:
This should be changed :-)
As of this writing (April 2013, Sage 5.8)
Heh. Oops.
comment:8 Changed 5 years ago by
- Branch changed from u/jhpalmieri/develop to adf07e5ef670bb28ccdc87efb8f3049753bde415
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Branch pushed to git repo; I updated commit sha1. New commits:
trac 23612: grammar