Opened 4 years ago

Closed 4 years ago

#23606 closed enhancement (fixed)

Add some abstract methods to Laurent polynomials base class

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.1
Component: basic arithmetic Keywords:
Cc: roed Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: b0cee8a (Commits, GitHub, GitLab) Commit: b0cee8ad65ef85126b9d0ebc29321449c199e1c4
Dependencies: Stopgaps:

Status badges

Description

Rename LaurentPolynomial_generic to LaurentPolynomial (it's not a "generic" implementation, it's an abstract base class) and put some abstract methods there, like cpdef _add_.

Change History (6)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/add_some_abstract_methods_to_laurent_polynomials_base_class

comment:2 Changed 4 years ago by jdemeyer

  • Cc roed added
  • Commit set to b0cee8ad65ef85126b9d0ebc29321449c199e1c4
  • Status changed from new to needs_review

New commits:

b0cee8aAdd some abstract methods to Laurent polynomials base class

comment:3 follow-up: Changed 4 years ago by tscrim

Should we worry about old pickles? Specifically, should we add a register_unpickle_override?

comment:4 in reply to: ↑ 3 Changed 4 years ago by jdemeyer

Replying to tscrim:

Should we worry about old pickles?

I don't think so because

  1. There shouldn't exist objects of type LaurentPolynomial_generic in the first place, only of subclasses.
  1. It's a Cython class so pickling probably won't work anyway.

comment:5 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Alright. Positive review.

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/add_some_abstract_methods_to_laurent_polynomials_base_class to b0cee8ad65ef85126b9d0ebc29321449c199e1c4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.