Opened 4 years ago

Closed 4 years ago

#23603 closed enhancement (fixed)

Fix cpdef declaration issues in modular and number fields

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.1
Component: cython Keywords:
Cc: roed Merged in:
Authors: David Roe, Jeroen Demeyer Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: 4f6ba69 (Commits, GitHub, GitLab) Commit: 4f6ba690f6387f5e272f476974555cf07c6ac137
Dependencies: Stopgaps:

Status badges

Description

Part of #23600.

Change History (6)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/23603

comment:2 Changed 4 years ago by jdemeyer

  • Commit set to 4f6ba690f6387f5e272f476974555cf07c6ac137

I agree with your change to modular. I added a straightforward fix for number fields, please review.


New commits:

3b649e2Add cpdef _add_(self, other) and cpdef _mul_(self, other) all over
3d2d294PEP 8 spacing
4f6ba69Fix cpdef declarations in number fields

comment:3 Changed 4 years ago by jdemeyer

  • Status changed from new to needs_review

comment:4 follow-up: Changed 4 years ago by roed

  • Reviewers set to David Roe
  • Status changed from needs_review to positive_review

Looks fine to me. Do you know what pynac_pow was?

comment:5 in reply to: ↑ 4 Changed 4 years ago by jdemeyer

Replying to roed:

Looks fine to me. Do you know what __pynac_pow was?

It seems to be introduced by accident in

commit 0daf6b1ae0a96c698dc69c15e18065600d3b64c3
Author: Mike Hansen <mhansen@gmail.com>
Date:   Tue May 19 16:11:30 2009 -0700

    Updates for Pynac-0.1.7, main symbolics switch (#5930)

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/23603 to 4f6ba690f6387f5e272f476974555cf07c6ac137
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.