Opened 4 years ago
Closed 4 years ago
#23589 closed enhancement (fixed)
py3: adding absolute imports in many pyx files
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.1 |
Component: | python3 | Keywords: | |
Cc: | jdemeyer | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Jeroen Demeyer |
Report Upstream: | N/A | Work issues: | |
Branch: | 4bf27e7 (Commits, GitHub, GitLab) | Commit: | 4bf27e784f8095b268aa0313334423ac3b14da0b |
Dependencies: | Stopgaps: |
Description (last modified by )
part of ticket #22808
chosen with the help of
grep -L "absolute_import" $(git grep -l "^import [^s\.]" *.pyx)
Change History (12)
comment:1 Changed 4 years ago by
- Branch set to u/chapoton/23589
- Commit set to 255f10a905b4bde57ce0ae4246c442bd59a7a777
- Status changed from new to needs_review
comment:3 Changed 4 years ago by
- Commit changed from 255f10a905b4bde57ce0ae4246c442bd59a7a777 to 8c36f04326d54376cf0fd4589884d5a94c84e11b
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
8c36f04 | adding a bunch of from __future__ import absolute_import in pyx files
|
comment:4 Changed 4 years ago by
- Description modified (diff)
- Summary changed from py3: absolute import in morphism.pyx to py3: adding absolute imports in many pyx files
comment:5 Changed 4 years ago by
- Description modified (diff)
comment:6 Changed 4 years ago by
oops, sorry, I changed my mind and decided to make a mass-addition instead. Do you still say "positive review if tests pass" ?
comment:7 Changed 4 years ago by
- Commit changed from 8c36f04326d54376cf0fd4589884d5a94c84e11b to 4bf27e784f8095b268aa0313334423ac3b14da0b
Branch pushed to git repo; I updated commit sha1. New commits:
4bf27e7 | trac 23589 one detail
|
comment:8 Changed 4 years ago by
Sure, looks good to me (if tests pass).
comment:9 Changed 4 years ago by
+1
comment:10 follow-up: ↓ 11 Changed 4 years ago by
- Status changed from needs_review to positive_review
Thanks. As bot is morally green, I am setting to positive.
Jeroen, do you agree on the idea of adding "absolute_import" to all pyx files ?
comment:11 in reply to: ↑ 10 Changed 4 years ago by
Replying to chapoton:
Jeroen, do you agree on the idea of adding "absolute_import" to all pyx files ?
- If you want to do that, why not all files (both
.pyx
and.py
)?
- If you want to do that, why not add
division, print_function
everywhere too?
comment:12 Changed 4 years ago by
- Branch changed from u/chapoton/23589 to 4bf27e784f8095b268aa0313334423ac3b14da0b
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
some absolute imports in cython