Opened 4 years ago

Closed 4 years ago

#23589 closed enhancement (fixed)

py3: adding absolute imports in many pyx files

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.1
Component: python3 Keywords:
Cc: jdemeyer Merged in:
Authors: Frédéric Chapoton Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 4bf27e7 (Commits, GitHub, GitLab) Commit: 4bf27e784f8095b268aa0313334423ac3b14da0b
Dependencies: Stopgaps:

Status badges

Description (last modified by chapoton)

part of ticket #22808

chosen with the help of

grep -L "absolute_import" $(git grep -l "^import [^s\.]" *.pyx)

Change History (12)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/23589
  • Commit set to 255f10a905b4bde57ce0ae4246c442bd59a7a777
  • Status changed from new to needs_review

New commits:

255f10asome absolute imports in cython

comment:2 Changed 4 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer

Positive review if tests pass.

comment:3 Changed 4 years ago by git

  • Commit changed from 255f10a905b4bde57ce0ae4246c442bd59a7a777 to 8c36f04326d54376cf0fd4589884d5a94c84e11b

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8c36f04adding a bunch of from __future__ import absolute_import in pyx files

comment:4 Changed 4 years ago by chapoton

  • Description modified (diff)
  • Summary changed from py3: absolute import in morphism.pyx to py3: adding absolute imports in many pyx files

comment:5 Changed 4 years ago by chapoton

  • Description modified (diff)

comment:6 Changed 4 years ago by chapoton

oops, sorry, I changed my mind and decided to make a mass-addition instead. Do you still say "positive review if tests pass" ?

comment:7 Changed 4 years ago by git

  • Commit changed from 8c36f04326d54376cf0fd4589884d5a94c84e11b to 4bf27e784f8095b268aa0313334423ac3b14da0b

Branch pushed to git repo; I updated commit sha1. New commits:

4bf27e7trac 23589 one detail

comment:8 Changed 4 years ago by jhpalmieri

Sure, looks good to me (if tests pass).

comment:9 Changed 4 years ago by jdemeyer

+1

comment:10 follow-up: Changed 4 years ago by chapoton

  • Status changed from needs_review to positive_review

Thanks. As bot is morally green, I am setting to positive.

Jeroen, do you agree on the idea of adding "absolute_import" to all pyx files ?

comment:11 in reply to: ↑ 10 Changed 4 years ago by jdemeyer

Replying to chapoton:

Jeroen, do you agree on the idea of adding "absolute_import" to all pyx files ?

  1. If you want to do that, why not all files (both .pyx and .py)?
  1. If you want to do that, why not add division, print_function everywhere too?

comment:12 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/23589 to 4bf27e784f8095b268aa0313334423ac3b14da0b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.