Opened 2 years ago

Closed 2 years ago

#23571 closed enhancement (fixed)

Veronese embeddings for projective subschemes

Reported by: gjorgenson Owned by:
Priority: minor Milestone: sage-8.1
Component: algebraic geometry Keywords:
Cc: bhutz Merged in:
Authors: Grayson Jorgenson Reviewers: Ben Hutz
Report Upstream: N/A Work issues:
Branch: 5bec3ad (Commits) Commit: 5bec3ad8b10bd727715ab7df4dae198753e82e2f
Dependencies: #23434 Stopgaps:

Description

Implement a function to return the degree d Veronese embedding of a projective subscheme.

Change History (7)

comment:1 Changed 2 years ago by gjorgenson

  • Branch set to u/gjorgenson/ticket/23571
  • Commit set to f17c8d3daba84ace58b8bc665e49a9487b6197ad

New commits:

dd44cc823571: implement Veronese embedding functionality
604287c23234: move subscheme code to resp. folders
a2ddbdfMerge branch 8.0.rc2 into subscheme_files
aeeae92Merge branch 8.1.beta0 into t/23434/subscheme_files
7c583b8Merge branch 8.1.beta1 into t/23434/subscheme_files
ccadd12Merge branch 'u/bhutz/subscheme_files' of git://trac.sagemath.org/sage into ticket/23571
f17c8d323571: exclude trivial case d = 0 which does not give an embedding

comment:2 Changed 2 years ago by gjorgenson

  • Status changed from new to needs_review

I implemented the Veronese embedding functionality in two functions. One at the level of projective spaces and one for subschemes which returns the map between the ambient spaces restricted to the subscheme and its image (using the existing _forward_image functionality for projective subschemes). I also merged with #23434 to preemptively address the conflict.

comment:3 Changed 2 years ago by bhutz

  • Reviewers set to Ben Hutz
  • Status changed from needs_review to needs_work

This looks good except for a very minor issue:

  • the two error messages lines 1153, 1662 do not have anything to fill in the %s.

comment:4 Changed 2 years ago by git

  • Commit changed from f17c8d3daba84ace58b8bc665e49a9487b6197ad to 5bec3ad8b10bd727715ab7df4dae198753e82e2f

Branch pushed to git repo; I updated commit sha1. New commits:

5bec3ad23571: fixed error messages in projective space veronese_embedding

comment:5 Changed 2 years ago by gjorgenson

  • Status changed from needs_work to needs_review

Thanks, fixed.

comment:6 Changed 2 years ago by bhutz

  • Status changed from needs_review to positive_review

comment:7 Changed 2 years ago by vbraun

  • Branch changed from u/gjorgenson/ticket/23571 to 5bec3ad8b10bd727715ab7df4dae198753e82e2f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.