Opened 4 years ago
Closed 4 years ago
#23555 closed defect (fixed)
Bounding box bug in Polyhedron plots
Reported by:  jipilab  Owned by:  

Priority:  major  Milestone:  sage8.2 
Component:  geometry  Keywords:  polyhedron, days88 
Cc:  moritz  Merged in:  
Authors:  Moritz Firsching  Reviewers:  JeanPhilippe Labbé, Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  3f02385 (Commits, GitHub, GitLab)  Commit:  3f02385aa21d875917a5aef1a26013f1005d56e4 
Dependencies:  Stopgaps: 
Description
As reported on sagedevel here (1) and there (2), when creating a polyhedron far from the origin, the bounding box for the plot of the polyhedron includes the origin by default and it makes the polyhedron appear small. This appears to be a bug in the polyhedron.plot
currently at line 1248
when an empty Graphics3d
object is created.
(1) https://groups.google.com/forum/#!topic/sagedevel/6vd6PM29YM
(2) https://groups.google.com/forum/#!msg/cocalc/YQQHboBCwPw/d8NlOS8BwAJ
Change History (12)
comment:1 Changed 4 years ago by
comment:2 Changed 4 years ago by
 Branch set to u/moritz/23555
comment:3 Changed 4 years ago by
 Commit set to 6fc28c0813efc50d296b16e59a0c4e5bedf431dd
Branch pushed to git repo; I updated commit sha1. New commits:
6fc28c0  added doctest

comment:4 Changed 4 years ago by
 Cc moritz added
 Keywords polyhedron added
 Status changed from new to needs_review
This fixes it, I guess. Check out the doctest. If unpatched, the output should be
((0.0, 0.0, 0.0), (101.0, 101.0, 101.0))
comment:5 Changed 4 years ago by
 Keywords days88 added
 Reviewers set to JeanPhilippe Labbé
 Status changed from needs_review to positive_review
Looks good to me.
comment:6 Changed 4 years ago by
 Status changed from positive_review to needs_work
Documentation doesn't build
comment:7 Changed 4 years ago by
 Commit changed from 6fc28c0813efc50d296b16e59a0c4e5bedf431dd to 17ad1012cf65152a43b862e18b2c0727107b3b0f
comment:8 Changed 4 years ago by
 Status changed from needs_work to needs_review
I hope that fixes the issue..
comment:9 Changed 4 years ago by
typo: "The origin is no included" >>> "The origin is not included"
comment:10 Changed 4 years ago by
 Commit changed from 17ad1012cf65152a43b862e18b2c0727107b3b0f to 3f02385aa21d875917a5aef1a26013f1005d56e4
comment:11 Changed 4 years ago by
 Milestone changed from sage8.1 to sage8.2
 Reviewers changed from JeanPhilippe Labbé to JeanPhilippe Labbé, Frédéric Chapoton
 Status changed from needs_review to positive_review
ok
comment:12 Changed 4 years ago by
 Branch changed from u/moritz/23555 to 3f02385aa21d875917a5aef1a26013f1005d56e4
 Resolution set to fixed
 Status changed from positive_review to closed
(for reference) difference between 2d and 3d plots: