Opened 2 years ago

Closed 12 months ago

Last modified 12 months ago

#23547 closed enhancement (fixed)

isl + polylib + barvinok packages

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-8.5
Component: packages: optional Keywords:
Cc: vdelecroix, mkoeppe, vinklein Merged in:
Authors: Vincent Delecroix Reviewers: Vincent Klein, Sébastien Labbé
Report Upstream: N/A Work issues:
Branch: 35989e9 (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by vdelecroix)

We package Sven Verdoolaege's barvinok package (for lattice points in polytopes etc). It has dependency isl and polylib..

Source codes at

Tarballs at


Remarks

  • islpy provides Python bindings to isl and can be installed using pip. Though it will bring its own copy of isl... Documentation. The islpy package also claims to provide bindings for barvinok (haven't tested). To enable:
    ./sage -pip install --verbose --install-option --conf:'USE_BARVINOK=True' --install-option --conf:'USE_SHIPPED_ISL=False' --install-option --conf:'USE_SHIPPED_IMATH=False' islpy
    
  • Related Python library: islplot (last update 4 years ago...)
  • More resources at http://polycomp.gforge.inria.fr/

Change History (21)

comment:1 in reply to: ↑ description Changed 2 years ago by jdemeyer

Replying to mkoeppe:

It will bring its own copy of isl.

I don't think this is acceptable.

comment:2 Changed 2 years ago by vdelecroix

  • Cc vdelecroix added

comment:3 Changed 2 years ago by vdelecroix

I succeeded installing the barvinok program in my Sage installation doing

$ git clone git://repo.or.cz/barvinok.git
$ cd barvinok
$ sage -sh
(sage-sh) $ ./get_submodules.sh
(sage-sh) $ sh autogen.sh
(sage-sh) $ ./configure NTL_GMP_LIP=on --prefix=$SAGE_LOCAL --with-gmp-prefix=$SAGE_LOCAL --with-ntl-prefix=$SAGE_LOCAL
(sage-sh) $ make
(sage-sh) $ make install

I think that for cleaner packaging all submodules (isl, pet, polylib) should actually be independent packages.

comment:4 Changed 2 years ago by vdelecroix

  • Description modified (diff)

comment:5 Changed 2 years ago by vdelecroix

  • Description modified (diff)

comment:6 Changed 12 months ago by vdelecroix

  • Authors set to Vincent Delecroix
  • Component changed from packages: experimental to packages: optional
  • Description modified (diff)
  • Milestone changed from sage-8.1 to sage-8.5

comment:7 Changed 12 months ago by vdelecroix

  • Branch set to u/vdelecroix/23547
  • Commit set to 82f0f8afd659ef271059f28242ac69c5b41e37fd

With the current branch at 82f0f8afd6 I do obtain compilation errors. I might have done something wrong. Problem discussed on isl-development mailing list.


New commits:

82f0f8a23547: package isl+polylib+barvinok
Last edited 12 months ago by vdelecroix (previous) (diff)

comment:8 Changed 12 months ago by vdelecroix

  • Description modified (diff)

comment:9 Changed 12 months ago by vdelecroix

  • Description modified (diff)

comment:10 Changed 12 months ago by git

  • Commit changed from 82f0f8afd659ef271059f28242ac69c5b41e37fd to 89c76dd6d607effb8cb39ebe8ed44c7b39a9d2eb

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

89c76dd23547: package isl+polylib+barvinok

comment:11 Changed 12 months ago by vdelecroix

  • Status changed from new to needs_review

The three spkg-check does pass on my computer... more testing needed.

comment:12 Changed 12 months ago by git

  • Commit changed from 89c76dd6d607effb8cb39ebe8ed44c7b39a9d2eb to 4984d397a24189ecc8ac1533245f63394401b869

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4984d3923547: package isl+polylib+barvinok

comment:13 Changed 12 months ago by git

  • Commit changed from 4984d397a24189ecc8ac1533245f63394401b869 to 35989e9894d2bf51e4359bb5ceb9be28b8e013cb

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

35989e923547: package isl+polylib+barvinok

comment:14 Changed 12 months ago by vdelecroix

  • Summary changed from Add isl and barvinok packages to isl + polylib + barvinok packages

comment:15 Changed 12 months ago by vdelecroix

  • Cc mkoeppe vinklein added

comment:16 Changed 12 months ago by vklein

Ticket installed and compiled on OSX.

The output of barvinok tests is pretty strange with repetition of 'o' and '.' characters.

$ sage -f -c barvinok
...
[barvinok-0.41.1] ./tests/supporting1 --specialization=df --primal --index=10 ok
[barvinok-0.41.1] ./tests/supporting1 --specialization=todd --primal --index=10 ok
[barvinok-0.41.1] ./tests/supporting2 --specialization=random --index=10o.......ooooooooooooooooooooooooo ok................................
[barvinok-0.41.1] ./tests/supporting2 --specialization=bf --index=10oooooooooooooooooooooooooooooooooooooooooo
[barvinok-0.41.1]  ok
[barvinok-0.41.1] ./tests/supporting2 --specialization=df --index=10./tests/ehrhart/g13.in
[barvinok-0.41.1]  ok
[barvinok-0.41.1] ./tests/supporting2 --specialization=todd --index=10..........ooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo
[barvinok-0.41.1]  ok
...

comment:17 Changed 12 months ago by vklein

Checks tests are successful for the three packages on OSX.

comment:18 Changed 12 months ago by slabbe

  • Reviewers set to Vincent Klein, Sébastien Labbé
  • Status changed from needs_review to positive_review

Installation tested on Ubuntu 16.04. sage -f -c barvinok works. Positive review.

comment:19 Changed 12 months ago by vdelecroix

Bravo! Merci!

comment:20 Changed 12 months ago by vbraun

  • Branch changed from u/vdelecroix/23547 to 35989e9894d2bf51e4359bb5ceb9be28b8e013cb
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:21 Changed 12 months ago by Konrad127123

  • Commit 35989e9894d2bf51e4359bb5ceb9be28b8e013cb deleted

Note that isl>=0.20 breaks compiling of gcc (fix in #26735), so this presumably makes make isl && make gcc fail, even on computers with system isl<0.20. (I have system isl=0.20 already, so I can't test that this is the case.)

Note: See TracTickets for help on using tickets.