#23533 closed defect (duplicate)

fail to build cryptominisat with some gcc versions

Reported by: vdelecroix Owned by:
Priority: critical Milestone: sage-duplicate/invalid/wontfix
Component: packages: optional Keywords: cryptominisat
Cc: saraedum, slelievre, tmonteil Merged in:
Authors: Reviewers:
Report Upstream: Fixed upstream, in a later stable release. Work issues:
Branch: Commit:
Dependencies: #25480 Stopgaps: #23969

Description (last modified by vdelecroix)

The compiler complains at

../src/scalmc.cpp: In member function 'bool CUSP::ScalApproxMC(SATCount&)':
../src/scalmc.cpp:554:40: error: call of overloaded 'abs(uint64_t)' is ambiguous
                 if (abs(hashCount-mPrev) <= 2 && mPrev != 0) {

See the logfile cryptominisat-5.0.1.log. Might be due to the recent gcc 7.1.1 that I am using

Upstream github issue at

https://github.com/msoos/cryptominisat/issues/403

Fixed in the new release, see #25480

Attachments (1)

cryptominisat-5.0.1.log (71.5 KB) - added by vdelecroix 23 months ago.

Download all attachments as: .zip

Change History (19)

Changed 23 months ago by vdelecroix

comment:1 Changed 23 months ago by vdelecroix

  • Description modified (diff)
  • Report Upstream changed from N/A to Reported upstream. No feedback yet.

comment:2 Changed 23 months ago by tmonteil

  • Report Upstream changed from Reported upstream. No feedback yet. to Fixed upstream, but not in a stable release.

comment:4 Changed 16 months ago by vdelecroix

  • Priority changed from major to blocker

comment:5 follow-up: Changed 16 months ago by fbissey

Do you want to upgrade to 5.0.2 even so it is marked as a pre-release? It should contain the fix.

comment:6 in reply to: ↑ 5 ; follow-up: Changed 16 months ago by vdelecroix

Replying to fbissey:

Do you want to upgrade to 5.0.2 even so it is marked as a pre-release? It should contain the fix.

5.0.2 does build on my computer. However, your patch osx_install_nameQA.patch does not apply anymore. Should it simply be removed? If not, I won't be able to adapt it.

comment:7 in reply to: ↑ 6 Changed 16 months ago by vdelecroix

Replying to vdelecroix:

Replying to fbissey:

Do you want to upgrade to 5.0.2 even so it is marked as a pre-release? It should contain the fix.

5.0.2 does build on my computer. However, your patch osx_install_nameQA.patch does not apply anymore. Should it simply be removed? If not, I won't be able to adapt it.

I opened a discussion about a release in issue 463.

comment:8 Changed 16 months ago by fbissey

The patch doesn't apply because there is too much fuzz but the issue hasn't been fixed. I must say I never followed with upstream to get them to fix those particular issues better than what they do now.

comment:9 Changed 16 months ago by fbissey

I inspected the stuff upstream did a bit more. I cannot say I think it is very good but it is worth trying without doing anything first. There is a lot more windows specific code now. I feel like src/CMakeLists.txt could use a trim but I may be arrogant there.

Last edited 16 months ago by fbissey (previous) (diff)

comment:10 Changed 16 months ago by rws

I have no problems building 5.0.1 with clang-4.

comment:11 Changed 16 months ago by rws

5.0.1 also builds fine with clang-5.0.1.

comment:12 Changed 16 months ago by rws

  • Summary changed from fail to build cryptominisat to fail to build cryptominisat with some gcc versions

comment:13 Changed 15 months ago by vbraun

  • Priority changed from blocker to critical

comment:14 Changed 14 months ago by jdemeyer

  • Stopgaps set to #23969

comment:15 follow-up: Changed 13 months ago by jdemeyer

Fixed by #25480?

comment:16 in reply to: ↑ 15 Changed 13 months ago by vdelecroix

  • Description modified (diff)
  • Milestone changed from sage-8.1 to sage-duplicate/invalid/wontfix
  • Status changed from new to needs_review

Replying to jdemeyer:

Fixed by #25480?

yes

comment:17 Changed 12 months ago by slelievre

  • Cc saraedum slelievre added
  • Dependencies set to #25480
  • Report Upstream changed from Fixed upstream, but not in a stable release. to Fixed upstream, in a later stable release.

The upgrade to a stable version of Cryptominisat containing the fix is at #25480.

Once #25480 is merged and closed, this can be closed too.

comment:18 Changed 12 months ago by jdemeyer

  • Resolution set to duplicate
  • Status changed from needs_review to closed
Note: See TracTickets for help on using tickets.