Opened 4 years ago
Closed 3 years ago
#23533 closed defect (duplicate)
fail to build cryptominisat with some gcc versions
| Reported by: | vdelecroix | Owned by: | |
|---|---|---|---|
| Priority: | critical | Milestone: | sage-duplicate/invalid/wontfix |
| Component: | packages: optional | Keywords: | cryptominisat |
| Cc: | saraedum, slelievre, tmonteil | Merged in: | |
| Authors: | Reviewers: | ||
| Report Upstream: | Fixed upstream, in a later stable release. | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | #25480 | Stopgaps: | #23969 |
Status badges
Description (last modified by )
The compiler complains at
../src/scalmc.cpp: In member function 'bool CUSP::ScalApproxMC(SATCount&)':
../src/scalmc.cpp:554:40: error: call of overloaded 'abs(uint64_t)' is ambiguous
if (abs(hashCount-mPrev) <= 2 && mPrev != 0) {
See the logfile cryptominisat-5.0.1.log. Might be due to the recent gcc 7.1.1 that I am using
Upstream github issue at
Fixed in the new release, see #25480
Attachments (1)
Change History (19)
Changed 4 years ago by
comment:1 Changed 4 years ago by
- Description modified (diff)
- Report Upstream changed from N/A to Reported upstream. No feedback yet.
comment:2 Changed 4 years ago by
- Report Upstream changed from Reported upstream. No feedback yet. to Fixed upstream, but not in a stable release.
comment:3 Changed 4 years ago by
comment:4 Changed 3 years ago by
- Priority changed from major to blocker
comment:5 follow-up: ↓ 6 Changed 3 years ago by
Do you want to upgrade to 5.0.2 even so it is marked as a pre-release? It should contain the fix.
comment:6 in reply to: ↑ 5 ; follow-up: ↓ 7 Changed 3 years ago by
Replying to fbissey:
Do you want to upgrade to 5.0.2 even so it is marked as a pre-release? It should contain the fix.
5.0.2 does build on my computer. However, your patch osx_install_nameQA.patch does not apply anymore. Should it simply be removed? If not, I won't be able to adapt it.
comment:7 in reply to: ↑ 6 Changed 3 years ago by
Replying to vdelecroix:
Replying to fbissey:
Do you want to upgrade to 5.0.2 even so it is marked as a pre-release? It should contain the fix.
5.0.2 does build on my computer. However, your patch
osx_install_nameQA.patchdoes not apply anymore. Should it simply be removed? If not, I won't be able to adapt it.
I opened a discussion about a release in issue 463.
comment:8 Changed 3 years ago by
The patch doesn't apply because there is too much fuzz but the issue hasn't been fixed. I must say I never followed with upstream to get them to fix those particular issues better than what they do now.
comment:9 Changed 3 years ago by
I inspected the stuff upstream did a bit more. I cannot say I think it is very good but it is worth trying without doing anything first. There is a lot more windows specific code now. I feel like src/CMakeLists.txt could use a trim but I may be arrogant there.
comment:10 Changed 3 years ago by
I have no problems building 5.0.1 with clang-4.
comment:11 Changed 3 years ago by
5.0.1 also builds fine with clang-5.0.1.
comment:12 Changed 3 years ago by
- Summary changed from fail to build cryptominisat to fail to build cryptominisat with some gcc versions
comment:13 Changed 3 years ago by
- Priority changed from blocker to critical
comment:14 Changed 3 years ago by
- Stopgaps set to #23969
comment:15 follow-up: ↓ 16 Changed 3 years ago by
Fixed by #25480?
comment:16 in reply to: ↑ 15 Changed 3 years ago by
- Description modified (diff)
- Milestone changed from sage-8.1 to sage-duplicate/invalid/wontfix
- Status changed from new to needs_review
comment:17 Changed 3 years ago by
- Cc saraedum slelievre added
- Dependencies set to #25480
- Report Upstream changed from Fixed upstream, but not in a stable release. to Fixed upstream, in a later stable release.
comment:18 Changed 3 years ago by
- Resolution set to duplicate
- Status changed from needs_review to closed
cf. https://github.com/msoos/cryptominisat/issues/422