#23512 closed enhancement (fixed)
Update Dokchitser's Lfunction script
Reported by:  alexjbest  Owned by:  

Priority:  minor  Milestone:  sage8.1 
Component:  scripts  Keywords:  sd87, dokchister 
Cc:  Merged in:  
Authors:  Alex J. Best  Reviewers:  Edgar Costa, Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  e72abf2 (Commits)  Commit:  
Dependencies:  Stopgaps: 
Description
The version of Tim Dokchitser's computel script is older than the one on his website. This ticket updates to the latest version.
The only change is the fix of an inequality.
Change History (14)
comment:1 Changed 21 months ago by
 Branch set to u/alexjbest/dokchitserupdate
comment:2 Changed 21 months ago by
 Commit set to bfc11dff7141ac967f07b574589c0c9f7026ed6d
 Status changed from new to needs_review
comment:3 Changed 21 months ago by
I think you should add doctests showing the impact of this update
comment:4 Changed 21 months ago by
 Reviewers set to Edgar Costa
 Status changed from needs_review to positive_review
comment:5 Changed 21 months ago by
The only difference is that the inequality
res > err
is replaced by
abs(res)>err
The old version didn't account for the res being negative.
comment:6 Changed 21 months ago by
 Status changed from positive_review to needs_work
Yes, I saw. Nevertheless, I guess that you should add a doctest demonstrating that the bug this ticket is supposed to fix is indeed fixed (as far as I understand, each ticket needs to include a doctest showing its benefit). You can add it in the section TESTS like this
TESTS: Check that `trac`:23512 is fixed:: ...
comment:7 Changed 21 months ago by
 Commit changed from bfc11dff7141ac967f07b574589c0c9f7026ed6d to 9ab81230f814b7e24d8f71a6abf3a85b24eb9796
Branch pushed to git repo; I updated commit sha1. New commits:
9ab8123  added doctest for dokchitser update 1.3.3>1.3.4, num_coeffs now works when spectral parameters have nonzero imaginary part, e.g. for maass forms

comment:8 Changed 21 months ago by
 Status changed from needs_work to needs_review
I agree that an example is a good idea, but I couldn't find one originally!
Thanks to some hints from Tim Dokchitser I have now added an example that failed previous to this change: The issue was with complex entries in gammaV which occur for Lfunctions of maass forms for example http://www.lmfdb.org/L/ModularForm/GL2/Q/Maass/4f4bf1c388aece438d000000/ , the lack of abs caused the cflength function to crash when it tried to check an inequality with a complex number.
comment:9 Changed 21 months ago by
The added example is missing the final ::
(and this line is too long and should be broken in 2 lines)
comment:10 Changed 21 months ago by
 Dependencies #22746 deleted
 Keywords dokchister added
 Milestone changed from sage8.0 to sage8.1
comment:11 Changed 21 months ago by
 Branch changed from u/alexjbest/dokchitserupdate to public/23512
 Commit changed from 9ab81230f814b7e24d8f71a6abf3a85b24eb9796 to e72abf286ca4c2ab252abeb61ea8f54eda31bef4
 Reviewers changed from Edgar Costa to Frédéric Chapoton
 Status changed from needs_review to positive_review
comment:12 Changed 21 months ago by
 Reviewers changed from Frédéric Chapoton to Edgar Costa, Frédéric Chapoton
comment:13 Changed 21 months ago by
 Branch changed from public/23512 to e72abf286ca4c2ab252abeb61ea8f54eda31bef4
 Resolution set to fixed
 Status changed from positive_review to closed
comment:14 Changed 17 months ago by
 Commit e72abf286ca4c2ab252abeb61ea8f54eda31bef4 deleted
New commits:
Update dokchitser's computel script