Opened 5 years ago

Closed 5 years ago

#23507 closed enhancement (fixed)

Exact ring attached to a p-adic ring or field

Reported by: David Roe Owned by:
Priority: major Milestone: sage-8.1
Component: padics Keywords: sd87, beginner
Cc: Merged in:
Authors: Adele Bourgeois Reviewers: Sara Chari
Report Upstream: N/A Work issues:
Branch: 070b7e0 (Commits, GitHub, GitLab) Commit: 070b7e0428f9614fdbdfbf7a0e66157e643aa0aa
Dependencies: #23331 Stopgaps:

Status badges

Description

#23331 introduced an exact_field method for p-adics. There should be a similar method exact_ring which returns ZZ.extension(self.defining_polynomial(exact=True)) (failing when the defining polynomial does not have integral coefficients).

Change History (5)

comment:1 Changed 5 years ago by David Roe

Dependencies: #23331

comment:2 Changed 5 years ago by Adèle Bourgeois

Branch: u/abourgeois/exact_ring_attached_to_a_p_adic_ring_or_field

comment:3 Changed 5 years ago by Adèle Bourgeois

Authors: Adele Bourgeois
Commit: 070b7e0428f9614fdbdfbf7a0e66157e643aa0aa
Keywords: beginner added
Status: newneeds_review

Last 10 new commits:

6ba62ddFix SEEALSO again
f6366b5Added exact_ring method
0b79df4gfg
b465407Added self argument in exact_ring
597cd38Added exact_ring method for extensions
1b86356Added an example
7d92776Added an example that raises a ValueError
86e1060Fix formatting of documentation
069a4b6More formatting of documentation
070b7e0Fix doctest

comment:4 Changed 5 years ago by Sara Chari

Reviewers: Sara Chari
Status: needs_reviewpositive_review

Looks good!

comment:5 Changed 5 years ago by Volker Braun

Branch: u/abourgeois/exact_ring_attached_to_a_p_adic_ring_or_field070b7e0428f9614fdbdfbf7a0e66157e643aa0aa
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.