Opened 3 years ago

Closed 3 years ago

#23503 closed enhancement (fixed)

Method denominator() for elements in CDVF

Reported by: caruso Owned by:
Priority: major Milestone: sage-8.1
Component: padics Keywords: sd87
Cc: roed, saraedum, TristanVaccon Merged in:
Authors: Xavier Caruso Reviewers: David Roe, Angelica Babei
Report Upstream: N/A Work issues:
Branch: 1ede8f6 (Commits) Commit: 1ede8f63e8604c33bfcb7e408ca6c19d955bea1d
Dependencies: Stopgaps:

Description (last modified by caruso)

Computing the intersection of two modules over a PID requires a method denominator(). This ticket implements this method for complete discrete valuation rings/fields. Here is an example showing how it works

    sage: K = Qp(5)
    sage: K(1/15).denominator()
    5 + 0(5^21)

Change History (5)

comment:1 Changed 3 years ago by caruso

  • Branch set to u/caruso/cdvf_denominator

comment:2 Changed 3 years ago by caruso

  • Authors set to Xavier Caruso
  • Commit set to 1ede8f63e8604c33bfcb7e408ca6c19d955bea1d
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

e0ef01aAdded a method denominator() to CDVF
34e5aacDefine denominator() for CDVR as well
1ede8f6Fix doctest

comment:3 Changed 3 years ago by roed

  • Reviewers set to David Roe

Looks good once patchbot is happy.

comment:4 Changed 3 years ago by ababei

  • Reviewers changed from David Roe to David Roe, Angelica Babei
  • Status changed from needs_review to positive_review

comment:5 Changed 3 years ago by vbraun

  • Branch changed from u/caruso/cdvf_denominator to 1ede8f63e8604c33bfcb7e408ca6c19d955bea1d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.