Opened 2 years ago

Closed 2 years ago

#23499 closed enhancement (fixed)

Compute conductor of abelian fields

Reported by: jwj Owned by:
Priority: major Milestone: sage-8.1
Component: number fields Keywords: sd87
Cc: Merged in:
Authors: John Jones Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: e966b85 (Commits) Commit: e966b85e8790d2d235894007ab91d666ec179453
Dependencies: #23474 Stopgaps:

Description

Add functionality to test if a number field is abelian, and if so, find its conductor. Covers part of ticket #9407

Change History (15)

comment:1 Changed 2 years ago by jwj

  • Branch set to u/jwj/ab2

comment:2 Changed 2 years ago by jwj

  • Commit set to a31c4754d74bf0ff56d1f58a20d74f76a3c204c2
  • Keywords sd87 added
  • Status changed from new to needs_review

New commits:

a31c475Fix ticket 23499 by adding functions to test if a number field is

comment:3 Changed 2 years ago by fli

  • Dependencies changed from 23474 to #23474

comment:4 Changed 2 years ago by abourgeois

  • Branch changed from u/jwj/ab2 to u/abourgeois/ab2

comment:5 Changed 2 years ago by abourgeois

  • Commit changed from a31c4754d74bf0ff56d1f58a20d74f76a3c204c2 to a4556481b365f3b7280a656c73b62132c753ef49
  • Status changed from needs_review to positive_review

All tests pass!

I removed the text "Integer which is the conductor of the field." following INPUT, as it did not belong there.


New commits:

a455648Fix Input of conductor method in the documentation

comment:6 Changed 2 years ago by chapoton

  • Status changed from positive_review to needs_work

bad syntax for the raise statement, not compatible with python 3

And there was no reviewer name...

Last edited 2 years ago by chapoton (previous) (diff)

comment:7 Changed 2 years ago by jwj

  • Branch changed from u/abourgeois/ab2 to u/jwj/ab2

comment:8 Changed 2 years ago by jwj

  • Commit changed from a4556481b365f3b7280a656c73b62132c753ef49 to a963561849dde87089659442aff91c6d2b3239d9

Fixed syntax of raise statement.


New commits:

a963561Fix raising of error to python 3 syntax
Last edited 2 years ago by jwj (previous) (diff)

comment:9 Changed 2 years ago by jwj

  • Status changed from needs_work to needs_review

comment:10 Changed 2 years ago by roed

  • Branch changed from u/jwj/ab2 to u/roed/ab2

comment:11 Changed 2 years ago by git

  • Commit changed from a963561849dde87089659442aff91c6d2b3239d9 to ce00f44fe1105af6ad7a62f7fc41cd3d92b4a651

Branch pushed to git repo; I updated commit sha1. New commits:

ce00f44Undo doctest change

comment:12 Changed 2 years ago by git

  • Commit changed from ce00f44fe1105af6ad7a62f7fc41cd3d92b4a651 to e966b85e8790d2d235894007ab91d666ec179453

Branch pushed to git repo; I updated commit sha1. New commits:

e966b85Style fixes and generalize square-of-prime check

comment:13 Changed 2 years ago by roed

  • Reviewers set to David Roe

I ran all tests, made a few style changes and changed [1,4,9,25,49,121] to more general code. If you're happy with the changes, feel free to set this to positive review.

comment:14 Changed 2 years ago by jwj

  • Status changed from needs_review to positive_review

comment:15 Changed 2 years ago by vbraun

  • Branch changed from u/roed/ab2 to e966b85e8790d2d235894007ab91d666ec179453
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.