Opened 4 years ago

Closed 4 years ago

#23493 closed enhancement (fixed)

Posets: Some crosslinks etc.

Reported by: jmantysalo Owned by:
Priority: minor Milestone: sage-8.1
Component: documentation Keywords:
Cc: Merged in:
Authors: Jori Mäntysalo Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: ed7346c (Commits, GitHub, GitLab) Commit: ed7346cbc14301cad1bf0841c17068d312ec7a74
Dependencies: Stopgaps:

Status badges

Description

This patch adds some crosslinks etc. Mostly bikeshedding, but there was also one broken link.

Change History (5)

comment:1 Changed 4 years ago by jmantysalo

  • Branch set to u/jmantysalo/poset-crosslinks-etc

comment:2 Changed 4 years ago by jmantysalo

  • Commit set to 3144b308c4b7d7857a737ba19da54d5075902028
  • Status changed from new to needs_review

New commits:

3144b30Minor documentation changes.

comment:3 follow-up: Changed 4 years ago by chapoton

  • Branch changed from u/jmantysalo/poset-crosslinks-etc to public/23493
  • Commit changed from 3144b308c4b7d7857a737ba19da54d5075902028 to ed7346cbc14301cad1bf0841c17068d312ec7a74
  • Reviewers set to Frédéric Chapoton

I have corrected some rather strange-sounding sentences.

And I also put back "whether", which is used in the rest of the file.

If you agree, you can set to positive.


New commits:

ed7346ctrac 23493 details

comment:4 in reply to: ↑ 3 Changed 4 years ago by jmantysalo

  • Status changed from needs_review to positive_review

Replying to chapoton:

If you agree, you can set to positive.

OK.

And I also put back "whether", which is used in the rest of the file.

There was a discussion about this in the sage-devel list, but I think I didn't read all of it. Currently the developer manual has an example "Return whether this integer is prime." Was that what we agreed? If so, I can later mass-change is_*-functions to use that.

comment:5 Changed 4 years ago by vbraun

  • Branch changed from public/23493 to ed7346cbc14301cad1bf0841c17068d312ec7a74
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.