Opened 5 years ago
Closed 5 years ago
#23483 closed enhancement (fixed)
ZZ → Zmod is surjective but not injective
| Reported by: | Julian Rüth | Owned by: | |
|---|---|---|---|
| Priority: | trivial | Milestone: | sage-8.1 |
| Component: | commutative algebra | Keywords: | sd87, beginner |
| Cc: | Merged in: | ||
| Authors: | Julian Rüth | Reviewers: | Adele Bourgeois |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 569cde2 (Commits, GitHub, GitLab) | Commit: | 569cde21ddc1ad06c844b0425f8dd924f38ddb57 |
| Dependencies: | #23204 | Stopgaps: |
Status badges
Description
Change History (12)
comment:1 Changed 5 years ago by
| Summary: | ZZ → Zmod is surjective → ZZ → Zmod is surjective but not injective |
|---|
comment:2 Changed 5 years ago by
| Branch: | → u/saraedum/zz___zmod_is_surjective_but_not_injective |
|---|
comment:3 Changed 5 years ago by
| Commit: | → 569cde21ddc1ad06c844b0425f8dd924f38ddb57 |
|---|---|
| Keywords: | sd87 added |
comment:4 Changed 5 years ago by
| Status: | new → needs_review |
|---|
comment:5 Changed 5 years ago by
| Keywords: | beginner added |
|---|
comment:6 Changed 5 years ago by
The doctests in the new code are raising errors.
This seems to be because ZZ.hom() creates a RingHomomorphism_coercion object, rather than an Integer_to_IntegerMod object.
comment:7 Changed 5 years ago by
| Status: | needs_review → needs_work |
|---|
comment:8 Changed 5 years ago by
| Dependencies: | → #23204 |
|---|---|
| Status: | needs_work → needs_review |
Thanks for checking. There was a dependency missing.
comment:9 Changed 5 years ago by
| Reviewers: | → Adele Bourgeois |
|---|---|
| Status: | needs_review → positive_review |
I noticed the same thing with the dependency. Everything works well now that it has been added.
comment:10 Changed 5 years ago by
| Status: | positive_review → needs_work |
|---|---|
| Work issues: | → failing doctest |
comment:11 Changed 5 years ago by
| Status: | needs_work → positive_review |
|---|---|
| Work issues: | failing doctest |
These tests are failing on other tickets as well. So does not seem to be related to this.
comment:12 Changed 5 years ago by
| Branch: | u/saraedum/zz___zmod_is_surjective_but_not_injective → 569cde21ddc1ad06c844b0425f8dd924f38ddb57 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
Z → Zmod is surjective but not injective