Opened 21 months ago

Closed 21 months ago

#23483 closed enhancement (fixed)

ZZ → Zmod is surjective but not injective

Reported by: saraedum Owned by:
Priority: trivial Milestone: sage-8.1
Component: commutative algebra Keywords: sd87, beginner
Cc: Merged in:
Authors: Julian Rüth Reviewers: Adele Bourgeois
Report Upstream: N/A Work issues:
Branch: 569cde2 (Commits) Commit: 569cde21ddc1ad06c844b0425f8dd924f38ddb57
Dependencies: #23204 Stopgaps:

Description


Change History (12)

comment:1 Changed 21 months ago by saraedum

  • Summary changed from ZZ → Zmod is surjective to ZZ → Zmod is surjective but not injective

comment:2 Changed 21 months ago by saraedum

  • Branch set to u/saraedum/zz___zmod_is_surjective_but_not_injective

comment:3 Changed 21 months ago by saraedum

  • Commit set to 569cde21ddc1ad06c844b0425f8dd924f38ddb57
  • Keywords sd87 added

New commits:

​569cde2Z → Zmod is surjective but not injective

comment:4 Changed 21 months ago by saraedum

  • Status changed from new to needs_review

comment:5 Changed 21 months ago by saraedum

  • Keywords beginner added

comment:6 Changed 21 months ago by xander.faber

The doctests in the new code are raising errors.

This seems to be because ZZ.hom() creates a RingHomomorphism_coercion object, rather than an Integer_to_IntegerMod object.

comment:7 Changed 21 months ago by xander.faber

  • Status changed from needs_review to needs_work

comment:8 Changed 21 months ago by saraedum

  • Dependencies set to #23204
  • Status changed from needs_work to needs_review

Thanks for checking. There was a dependency missing.

comment:9 Changed 21 months ago by abourgeois

  • Reviewers set to Adele Bourgeois
  • Status changed from needs_review to positive_review

I noticed the same thing with the dependency. Everything works well now that it has been added.

comment:10 Changed 21 months ago by saraedum

  • Status changed from positive_review to needs_work
  • Work issues set to failing doctest

comment:11 Changed 21 months ago by saraedum

  • Status changed from needs_work to positive_review
  • Work issues failing doctest deleted

These tests are failing on other tickets as well. So does not seem to be related to this.

comment:12 Changed 21 months ago by vbraun

  • Branch changed from u/saraedum/zz___zmod_is_surjective_but_not_injective to 569cde21ddc1ad06c844b0425f8dd924f38ddb57
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.