Opened 2 years ago

Closed 2 years ago

#23479 closed enhancement (fixed)

Number field method to return absolute value with respect to a place

Reported by: mwest Owned by:
Priority: major Milestone: sage-8.1
Component: number fields Keywords: S-unit-equation, Places, sd87
Cc: Merged in:
Authors: Alejandra Alvarado, Angelos Koutsianas, Beth Malmskog, Chris Rasmussen, Christelle Vincent, Mckenzie West Reviewers: Sara Chari
Report Upstream: N/A Work issues:
Branch: 5ce40ee (Commits) Commit: 5ce40eee4aadaa273703d8101419f729b9451e17
Dependencies: #23476 Stopgaps:

Description


Change History (10)

comment:1 Changed 2 years ago by mwest

  • Dependencies set to #23476

comment:2 Changed 2 years ago by mwest

  • Keywords S-unit-equation Places sd87 added

comment:3 Changed 2 years ago by mwest

  • Branch set to u/mwest/number_field_method_to_return_absolute_value_with_respect_to_a_place

comment:4 Changed 2 years ago by mwest

  • Commit set to 93c0679eb4d12162c0438a9ef3a693c223040054
  • Status changed from new to needs_review

New commits:

385b467added abs_val method to number fields
67b8f93Added function to end of number_field.py
52f681bDefined RR correctly
1697ce4Removed prec from inputs in doc string
15473f5merge for dependencies
93c0679Added abs_val method to NumberField

comment:5 Changed 2 years ago by mwest

  • Status changed from needs_review to needs_work

comment:6 Changed 2 years ago by mwest

  • Status changed from needs_work to needs_review

comment:7 Changed 2 years ago by schari

  • Reviewers set to Sara Chari
  • Status changed from needs_review to positive_review

Looks good.

comment:8 Changed 2 years ago by git

  • Commit changed from 93c0679eb4d12162c0438a9ef3a693c223040054 to 5ce40eee4aadaa273703d8101419f729b9451e17
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

5ce40eeR now defined with input precision instead of default 53

comment:9 Changed 2 years ago by schari

  • Status changed from needs_review to positive_review

Reviewed again- looks good.

comment:10 Changed 2 years ago by vbraun

  • Branch changed from u/mwest/number_field_method_to_return_absolute_value_with_respect_to_a_place to 5ce40eee4aadaa273703d8101419f729b9451e17
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.