Opened 2 years ago

Closed 2 years ago

#23473 closed defect (fixed)

Integers(1)(1).is_one() should be True

Reported by: edgarcosta Owned by:
Priority: major Milestone: sage-8.1
Component: commutative algebra Keywords: sd87
Cc: roed, saraedum, slelievre Merged in:
Authors: Edgar Costa, David Ayotte Reviewers: Freda Li
Report Upstream: N/A Work issues:
Branch: d38d57d (Commits) Commit: d38d57d295b0b9d2b2589cabe2b3186af1fcab47
Dependencies: Stopgaps:

Description (last modified by edgarcosta)

Integers(1) is the zero ring, where its single element is the additive identity and multiplicative identity (aka one).

Change History (10)

comment:1 Changed 2 years ago by edgarcosta

  • Summary changed from Change Error message for splitting fields to please close this ticket

comment:2 Changed 2 years ago by edgarcosta

  • Component changed from PLEASE CHANGE to commutative algebra
  • Description modified (diff)
  • Summary changed from please close this ticket to Integers(1)(1).is_one() should be True
  • Type changed from PLEASE CHANGE to defect

comment:3 Changed 2 years ago by slelievre

  • Cc roed saraedum slelievre added
  • Keywords sd87 added

Or to put it another way:

Current:

sage: Zmod(1).one().is_one()
False

Expected:

sage: Zmod(1).one().is_one()
True

comment:4 Changed 2 years ago by davidayotte

  • Branch set to u/davidayotte/integers_1__1__is_one___should_be_true

comment:5 Changed 2 years ago by davidayotte

  • Commit set to d38d57d295b0b9d2b2589cabe2b3186af1fcab47
  • Status changed from new to needs_review

New commits:

ad96bcatring to fix
d38d57dfixing introduced typo in previous commit

comment:6 Changed 2 years ago by edgarcosta

  • Status changed from needs_review to positive_review

I discussed this with David Roe, and he agrees that this looks like a good fix.

comment:7 Changed 2 years ago by saraedum

  • Status changed from positive_review to needs_info

Please fill in your real names as Authors and Reviewers :)

comment:8 Changed 2 years ago by edgarcosta

  • Authors set to Edgar Costa, David Ayotte
  • Status changed from needs_info to needs_review

comment:9 Changed 2 years ago by fli

  • Reviewers set to Freda Li
  • Status changed from needs_review to positive_review

Looks good to me.

comment:10 Changed 2 years ago by vbraun

  • Branch changed from u/davidayotte/integers_1__1__is_one___should_be_true to d38d57d295b0b9d2b2589cabe2b3186af1fcab47
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.