#23471 closed enhancement (fixed)

Conversion between p-adic rings and fields with the same defining polynomial

Reported by: roed Owned by:
Priority: major Milestone: sage-8.1
Component: padics Keywords: sd87
Cc: caruso Merged in:
Authors: David Roe Reviewers: Julian Rüth
Report Upstream: N/A Work issues:
Branch: 0c58970 (Commits) Commit: 0c58970be009778cc52d75b6947c2e142e1cfdb3
Dependencies: #14825 Stopgaps:

Description

It should be possible to convert between extensions with the same defining polynomial.

Attachments (1)

23471_over_14825.diff (11.8 KB) - added by roed 19 months ago.
Diff against #14825 for ease of review

Download all attachments as: .zip

Change History (31)

comment:1 Changed 20 months ago by roed

  • Dependencies changed from #20310 to #20310, #14825

comment:2 Changed 20 months ago by roed

  • Branch set to u/roed/padic_ext_conversion

comment:3 Changed 20 months ago by git

  • Commit set to 89f31de47adc6f27dea094bfd576f226c606ff7c

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

85019ccFix errors due to moving digits code earlier in the change function
7f96697Fixed typo with variable assignment
bbb7268added doctests
ee461b6merge with develop
8081eabadded doctests after fixing conflicts
063b58cMerge branch 'develop' into t/20073/ticket/20073
48be601Added documentation to verify that the extension has the right defining polynomial
921af5eChanging modulus and defining_polynomial to use an exact keyword
39043f1Merge branch 't/23331/allow_exact_defining_polynomials_for_p_adic_extensions' into t/20310/change_precision
89f31deMerge branch 't/20310/change_precision' into t/23471/padic_ext_conversion

comment:4 Changed 20 months ago by git

  • Commit changed from 89f31de47adc6f27dea094bfd576f226c606ff7c to 844bfc78aad91b6df114ca8a9872f472207431ca

Branch pushed to git repo; I updated commit sha1. New commits:

844bfc7Add ability to convert from orders in number fields with the same defining polynomial

comment:5 Changed 20 months ago by git

  • Commit changed from 844bfc78aad91b6df114ca8a9872f472207431ca to 1447fb36446e7eeb67284503fd0a7359c90cc4b6

Branch pushed to git repo; I updated commit sha1. New commits:

1447fb3Fixing doctest errors

comment:6 Changed 20 months ago by roed

  • Status changed from new to needs_review

comment:7 Changed 20 months ago by git

  • Commit changed from 1447fb36446e7eeb67284503fd0a7359c90cc4b6 to 8a923d4b367b74df3f13a9e6d91c68268cd0f186

Branch pushed to git repo; I updated commit sha1. New commits:

8a923d4Add _number_field_ method for converting the exact_field

comment:8 Changed 20 months ago by git

  • Commit changed from 8a923d4b367b74df3f13a9e6d91c68268cd0f186 to b7a0bffd9e59fed41cd59b40051e49c823c8e7d1

Branch pushed to git repo; I updated commit sha1. New commits:

b7a0bffFix orders

comment:9 Changed 20 months ago by roed

Okay, all tests pass in sage/rings.

comment:10 Changed 20 months ago by git

  • Commit changed from b7a0bffd9e59fed41cd59b40051e49c823c8e7d1 to a29bf7ab45eb479a7e8fd0c374aa72cb973df261

Branch pushed to git repo; I updated commit sha1. New commits:

77779eaminor docstring changes
6e2495fMerge branch 't/23331/allow_exact_defining_polynomials_for_p_adic_extensions' into t/20310/change_precision
7428353minor docstring fixes
bd15d71add exact keyword
99dccf6Merge branch 't/23331/allow_exact_defining_polynomials_for_p_adic_extensions' into t/20310/change_precision
ef4ed33Fix SEEALSO:
1754b44Fix exact=True errors in the right branch
a29bf7aMerge branch 't/20310/change_precision' into t/23471/padic_ext_conversion

comment:11 Changed 20 months ago by roed

And I've merged in the changes from #20310.

comment:12 Changed 20 months ago by git

  • Commit changed from a29bf7ab45eb479a7e8fd0c374aa72cb973df261 to 9763d7a15fe214c1ea66e6af3dd94097614457b8

Branch pushed to git repo; I updated commit sha1. New commits:

f985aa0Add ability to call with arguments
9763d7aFix implementation of _call_with_args

comment:13 Changed 20 months ago by git

  • Commit changed from 9763d7a15fe214c1ea66e6af3dd94097614457b8 to 3b52f2ce29102b3470e06779503282f5b24771fd

Branch pushed to git repo; I updated commit sha1. New commits:

3b52f2cFix bug from args being a tuple, not a list

comment:14 Changed 20 months ago by saraedum

  • Authors set to David Roe

comment:15 Changed 20 months ago by caruso

  • Cc caruso added

comment:16 Changed 20 months ago by git

  • Commit changed from 3b52f2ce29102b3470e06779503282f5b24771fd to 1d1ad897cce4dc99273c3943428432709920abf7

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

1ec63e7Merge branch 'u/roed/polynomial_representation_of_a_padic_number' of git://trac.sagemath.org/sage into t/14825/polynomial_representation_of_a_padic_number
7f87069Fix segfault
b9c2fe4Fix pickling of sections for p-adic coercions
6ba62ddFix SEEALSO again
e9c4c39Merge branch 'u/roed/allow_exact_defining_polynomials_for_p_adic_extensions' of git://trac.sagemath.org/sage into t/23331/allow_exact_defining_polynomials_for_p_adic_extensions
561f5acFix doctest errors
3142701Merge branch 'u/roed/change_precision' of git://trac.sagemath.org/sage into t/20310/change_precision
138d939Fix string representation doctest from #22103
1eeb367Merge branch 't/20310/change_precision' into t/14825/polynomial_representation_of_a_padic_number
1d1ad89Merge branch 'u/roed/padic_ext_conversion' of git://trac.sagemath.org/sage into t/23471/padic_ext_conversion

comment:17 Changed 20 months ago by roed

I've attached a diff against #14825 for ease of review

comment:18 Changed 20 months ago by roed

  • Dependencies changed from #20310, #14825 to #14825

Update dependency chain (#14825 depends on #20310).

comment:19 Changed 20 months ago by git

  • Commit changed from 1d1ad897cce4dc99273c3943428432709920abf7 to 2b93c3caacf2b23b4384a2242856b983a15efedb

Branch pushed to git repo; I updated commit sha1. New commits:

2b93c3cMerge branch 'develop' into t/23471/padic_ext_conversion

comment:20 Changed 19 months ago by git

  • Commit changed from 2b93c3caacf2b23b4384a2242856b983a15efedb to 3fc818a3f22f5c0db2bea6cea95e7cc67771638b

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

1bb288fprotect LaTeX commands
054e5d6clarify where _list_zero comes from
0b7fd02default docstring layout
def3897replace p with pi and clarify meaning of expansion
99c40d6add unit test for expansion
6732d38coefficients might be lists in the maximal unramified subextension
acc606aMerge branch 'u/saraedum/polynomial_representation_of_a_padic_number' of git://trac.sagemath.org/sage into t/14825/polynomial_representation_of_a_padic_number
40737f6Fix some of the errors in _test_expansion
6efed0bMerge branch 'u/roed/polynomial_representation_of_a_padic_number' of git://trac.sagemath.org/sage into t/14825/polynomial_representation_of_a_padic_number
3fc818aMerge branch 'u/roed/padic_ext_conversion' of git://trac.sagemath.org/sage into t/23471/padic_ext_conversion

comment:21 Changed 19 months ago by git

  • Commit changed from 3fc818a3f22f5c0db2bea6cea95e7cc67771638b to c594d3ab80d744e285aa8fb0da601019fe7a2ebd

Branch pushed to git repo; I updated commit sha1. New commits:

f80ca76Working on adding iterators
030251cRestructing of p-adic expansions
3c912f9Adding documentation and making small changes to names
7e037b3cleaning up a couple of hyperelliptic curve changes
acf6b66Fix implementation in linear_code that used padded_list
c594d3aMerge branch 't/14825/polynomial_representation_of_a_padic_number' into t/23471/padic_ext_conversion

Changed 19 months ago by roed

Diff against #14825 for ease of review

comment:22 Changed 19 months ago by git

  • Commit changed from c594d3ab80d744e285aa8fb0da601019fe7a2ebd to ee0ca36c6ef006541b5c775767a22a855d3319b3

Branch pushed to git repo; I updated commit sha1. New commits:

ecd3266Fix NOTES
8daa22dFix izip
ee0ca36Fixing documentation

comment:23 Changed 19 months ago by git

  • Commit changed from ee0ca36c6ef006541b5c775767a22a855d3319b3 to 8f34757e2825cb4c26110f729f664135b2872e12

Branch pushed to git repo; I updated commit sha1. New commits:

1f8aa2eFix NOTES
5cf279bFix izip
d7d5fb6Fixing documentation
8f34757Merge branch 't/14825/polynomial_representation_of_a_padic_number' into t/23471/padic_ext_conversion

comment:24 Changed 18 months ago by saraedum

  • Branch changed from u/roed/padic_ext_conversion to u/saraedum/padic_ext_conversion

comment:25 Changed 18 months ago by git

  • Commit changed from 8f34757e2825cb4c26110f729f664135b2872e12 to d5abeb89ea8326e6be55600bf37be9e1da99c3f4

Branch pushed to git repo; I updated commit sha1. New commits:

d5abeb8minor docstring fixes

comment:26 Changed 18 months ago by saraedum

  • Reviewers set to Julian Rüth
  • Status changed from needs_review to positive_review

comment:27 Changed 18 months ago by roed

  • Branch changed from u/saraedum/padic_ext_conversion to u/roed/padic_ext_conversion

comment:28 Changed 18 months ago by roed

  • Commit changed from d5abeb89ea8326e6be55600bf37be9e1da99c3f4 to 0c58970be009778cc52d75b6947c2e142e1cfdb3

Merging in develop and most recent #14825 to see if it resolves patchbot plugin complaints....


New commits:

b81b722Remove use of depraceted list()
04a1579Fix NOTES blocks
6764ea2Merge branch 'develop' into t/14825/polynomial_representation_of_a_padic_number
0c58970Merge branch 't/14825/polynomial_representation_of_a_padic_number' into t/23471/padic_ext_conversion

comment:29 Changed 18 months ago by roed

The plugin complaints seem to be gone.

comment:30 Changed 18 months ago by vbraun

  • Branch changed from u/roed/padic_ext_conversion to 0c58970be009778cc52d75b6947c2e142e1cfdb3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.