Opened 2 years ago
Closed 22 months ago
#23471 closed enhancement (fixed)
Conversion between padic rings and fields with the same defining polynomial
Reported by:  roed  Owned by:  

Priority:  major  Milestone:  sage8.1 
Component:  padics  Keywords:  sd87 
Cc:  caruso  Merged in:  
Authors:  David Roe  Reviewers:  Julian Rüth 
Report Upstream:  N/A  Work issues:  
Branch:  0c58970 (Commits)  Commit:  0c58970be009778cc52d75b6947c2e142e1cfdb3 
Dependencies:  #14825  Stopgaps: 
Description
It should be possible to convert between extensions with the same defining polynomial.
Attachments (1)
Change History (31)
comment:1 Changed 2 years ago by
 Dependencies changed from #20310 to #20310, #14825
comment:2 Changed 2 years ago by
 Branch set to u/roed/padic_ext_conversion
comment:3 Changed 2 years ago by
 Commit set to 89f31de47adc6f27dea094bfd576f226c606ff7c
comment:4 Changed 2 years ago by
 Commit changed from 89f31de47adc6f27dea094bfd576f226c606ff7c to 844bfc78aad91b6df114ca8a9872f472207431ca
Branch pushed to git repo; I updated commit sha1. New commits:
844bfc7  Add ability to convert from orders in number fields with the same defining polynomial

comment:5 Changed 2 years ago by
 Commit changed from 844bfc78aad91b6df114ca8a9872f472207431ca to 1447fb36446e7eeb67284503fd0a7359c90cc4b6
Branch pushed to git repo; I updated commit sha1. New commits:
1447fb3  Fixing doctest errors

comment:6 Changed 2 years ago by
 Status changed from new to needs_review
comment:7 Changed 2 years ago by
 Commit changed from 1447fb36446e7eeb67284503fd0a7359c90cc4b6 to 8a923d4b367b74df3f13a9e6d91c68268cd0f186
Branch pushed to git repo; I updated commit sha1. New commits:
8a923d4  Add _number_field_ method for converting the exact_field

comment:8 Changed 2 years ago by
 Commit changed from 8a923d4b367b74df3f13a9e6d91c68268cd0f186 to b7a0bffd9e59fed41cd59b40051e49c823c8e7d1
Branch pushed to git repo; I updated commit sha1. New commits:
b7a0bff  Fix orders

comment:9 Changed 2 years ago by
Okay, all tests pass in sage/rings
.
comment:10 Changed 2 years ago by
 Commit changed from b7a0bffd9e59fed41cd59b40051e49c823c8e7d1 to a29bf7ab45eb479a7e8fd0c374aa72cb973df261
Branch pushed to git repo; I updated commit sha1. New commits:
77779ea  minor docstring changes

6e2495f  Merge branch 't/23331/allow_exact_defining_polynomials_for_p_adic_extensions' into t/20310/change_precision

7428353  minor docstring fixes

bd15d71  add exact keyword

99dccf6  Merge branch 't/23331/allow_exact_defining_polynomials_for_p_adic_extensions' into t/20310/change_precision

ef4ed33  Fix SEEALSO:

1754b44  Fix exact=True errors in the right branch

a29bf7a  Merge branch 't/20310/change_precision' into t/23471/padic_ext_conversion

comment:11 Changed 2 years ago by
And I've merged in the changes from #20310.
comment:12 Changed 2 years ago by
 Commit changed from a29bf7ab45eb479a7e8fd0c374aa72cb973df261 to 9763d7a15fe214c1ea66e6af3dd94097614457b8
comment:13 Changed 2 years ago by
 Commit changed from 9763d7a15fe214c1ea66e6af3dd94097614457b8 to 3b52f2ce29102b3470e06779503282f5b24771fd
Branch pushed to git repo; I updated commit sha1. New commits:
3b52f2c  Fix bug from args being a tuple, not a list

comment:14 Changed 2 years ago by
comment:15 Changed 2 years ago by
 Cc caruso added
comment:16 Changed 2 years ago by
 Commit changed from 3b52f2ce29102b3470e06779503282f5b24771fd to 1d1ad897cce4dc99273c3943428432709920abf7
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
1ec63e7  Merge branch 'u/roed/polynomial_representation_of_a_padic_number' of git://trac.sagemath.org/sage into t/14825/polynomial_representation_of_a_padic_number

7f87069  Fix segfault

b9c2fe4  Fix pickling of sections for padic coercions

6ba62dd  Fix SEEALSO again

e9c4c39  Merge branch 'u/roed/allow_exact_defining_polynomials_for_p_adic_extensions' of git://trac.sagemath.org/sage into t/23331/allow_exact_defining_polynomials_for_p_adic_extensions

561f5ac  Fix doctest errors

3142701  Merge branch 'u/roed/change_precision' of git://trac.sagemath.org/sage into t/20310/change_precision

138d939  Fix string representation doctest from #22103

1eeb367  Merge branch 't/20310/change_precision' into t/14825/polynomial_representation_of_a_padic_number

1d1ad89  Merge branch 'u/roed/padic_ext_conversion' of git://trac.sagemath.org/sage into t/23471/padic_ext_conversion

comment:17 Changed 2 years ago by
I've attached a diff against #14825 for ease of review
comment:18 Changed 2 years ago by
 Dependencies changed from #20310, #14825 to #14825
comment:19 Changed 2 years ago by
 Commit changed from 1d1ad897cce4dc99273c3943428432709920abf7 to 2b93c3caacf2b23b4384a2242856b983a15efedb
Branch pushed to git repo; I updated commit sha1. New commits:
2b93c3c  Merge branch 'develop' into t/23471/padic_ext_conversion

comment:20 Changed 2 years ago by
 Commit changed from 2b93c3caacf2b23b4384a2242856b983a15efedb to 3fc818a3f22f5c0db2bea6cea95e7cc67771638b
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
1bb288f  protect LaTeX commands

054e5d6  clarify where _list_zero comes from

0b7fd02  default docstring layout

def3897  replace p with pi and clarify meaning of expansion

99c40d6  add unit test for expansion

6732d38  coefficients might be lists in the maximal unramified subextension

acc606a  Merge branch 'u/saraedum/polynomial_representation_of_a_padic_number' of git://trac.sagemath.org/sage into t/14825/polynomial_representation_of_a_padic_number

40737f6  Fix some of the errors in _test_expansion

6efed0b  Merge branch 'u/roed/polynomial_representation_of_a_padic_number' of git://trac.sagemath.org/sage into t/14825/polynomial_representation_of_a_padic_number

3fc818a  Merge branch 'u/roed/padic_ext_conversion' of git://trac.sagemath.org/sage into t/23471/padic_ext_conversion

comment:21 Changed 23 months ago by
 Commit changed from 3fc818a3f22f5c0db2bea6cea95e7cc67771638b to c594d3ab80d744e285aa8fb0da601019fe7a2ebd
Branch pushed to git repo; I updated commit sha1. New commits:
f80ca76  Working on adding iterators

030251c  Restructing of padic expansions

3c912f9  Adding documentation and making small changes to names

7e037b3  cleaning up a couple of hyperelliptic curve changes

acf6b66  Fix implementation in linear_code that used padded_list

c594d3a  Merge branch 't/14825/polynomial_representation_of_a_padic_number' into t/23471/padic_ext_conversion

comment:22 Changed 23 months ago by
 Commit changed from c594d3ab80d744e285aa8fb0da601019fe7a2ebd to ee0ca36c6ef006541b5c775767a22a855d3319b3
comment:23 Changed 23 months ago by
 Commit changed from ee0ca36c6ef006541b5c775767a22a855d3319b3 to 8f34757e2825cb4c26110f729f664135b2872e12
comment:24 Changed 22 months ago by
 Branch changed from u/roed/padic_ext_conversion to u/saraedum/padic_ext_conversion
comment:25 Changed 22 months ago by
 Commit changed from 8f34757e2825cb4c26110f729f664135b2872e12 to d5abeb89ea8326e6be55600bf37be9e1da99c3f4
Branch pushed to git repo; I updated commit sha1. New commits:
d5abeb8  minor docstring fixes

comment:26 Changed 22 months ago by
 Reviewers set to Julian Rüth
 Status changed from needs_review to positive_review
comment:27 Changed 22 months ago by
 Branch changed from u/saraedum/padic_ext_conversion to u/roed/padic_ext_conversion
comment:28 Changed 22 months ago by
 Commit changed from d5abeb89ea8326e6be55600bf37be9e1da99c3f4 to 0c58970be009778cc52d75b6947c2e142e1cfdb3
Merging in develop and most recent #14825 to see if it resolves patchbot plugin complaints....
New commits:
b81b722  Remove use of depraceted list()

04a1579  Fix NOTES blocks

6764ea2  Merge branch 'develop' into t/14825/polynomial_representation_of_a_padic_number

0c58970  Merge branch 't/14825/polynomial_representation_of_a_padic_number' into t/23471/padic_ext_conversion

comment:29 Changed 22 months ago by
The plugin complaints seem to be gone.
comment:30 Changed 22 months ago by
 Branch changed from u/roed/padic_ext_conversion to 0c58970be009778cc52d75b6947c2e142e1cfdb3
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
Fix errors due to moving digits code earlier in the change function
Fixed typo with variable assignment
added doctests
merge with develop
added doctests after fixing conflicts
Merge branch 'develop' into t/20073/ticket/20073
Added documentation to verify that the extension has the right defining polynomial
Changing modulus and defining_polynomial to use an exact keyword
Merge branch 't/23331/allow_exact_defining_polynomials_for_p_adic_extensions' into t/20310/change_precision
Merge branch 't/20310/change_precision' into t/23471/padic_ext_conversion