Opened 4 years ago

Closed 4 years ago

#23467 closed defect (fixed)

fix cardinality and iteration of univariate polynomial ring quotients

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-8.1
Component: algebra Keywords: sd87
Cc: Merged in:
Authors: Vincent Delecroix Reviewers: Adele Bourgeois
Report Upstream: N/A Work issues:
Branch: c2b70d1 (Commits, GitHub, GitLab) Commit: c2b70d185da72c4d74c4b93ba17ca5c0ffdfa19e
Dependencies: Stopgaps:

Status badges

Description (last modified by vdelecroix)

  • order is a duplicate of cardinality that is moreover wrong
    sage: QQ['x'].quo(1).order()
    A positive finite number
    
  • cardinality may return Python integers
    sage: type(QQ['x'].quo(1).cardinality())
    <type 'int'>
    
  • iteration not possible
    sage: R.<x> = GF(2)[]
    sage: list(R.quo(x^3 - x + 1))
    Traceback (most recent call last):
    ...
    NotImplementedError: object does not support iteration
    

see also this question on ask.

Change History (8)

comment:1 Changed 4 years ago by vdelecroix

  • Description modified (diff)

comment:2 Changed 4 years ago by vdelecroix

  • Description modified (diff)

comment:3 Changed 4 years ago by vdelecroix

  • Authors set to Vincent Delecroix
  • Branch set to u/vdelecroix/23467
  • Commit set to 429af56f00f9d044130d586706a38d54f3e62591
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

429af5623467: improve univariate polynomial ring quotients

comment:4 Changed 4 years ago by git

  • Commit changed from 429af56f00f9d044130d586706a38d54f3e62591 to c2b70d185da72c4d74c4b93ba17ca5c0ffdfa19e

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

c2b70d123467: improve univariate polynomial ring quotients

comment:5 Changed 4 years ago by abourgeois

  • Authors changed from Vincent Delecroix to Vincent Delecroix, Adele Bourgeois
  • Keywords sd87 added
  • Status changed from needs_review to positive_review

Looks good.

comment:6 follow-up: Changed 4 years ago by vdelecroix

  • Authors changed from Vincent Delecroix, Adele Bourgeois to Vincent Delecroix
  • Reviewers set to Adele Bourgeois

Adele,

When you review a ticket you should not put your names in the Authors field but Reviewers one.

comment:7 in reply to: ↑ 6 Changed 4 years ago by abourgeois

My bad! Still new to this reviewing process.. thanks!

Replying to vdelecroix:

Adele,

When you review a ticket you should not put your names in the Authors field but Reviewers one.

comment:8 Changed 4 years ago by vbraun

  • Branch changed from u/vdelecroix/23467 to c2b70d185da72c4d74c4b93ba17ca5c0ffdfa19e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.