Opened 4 years ago

Closed 4 years ago

#23466 closed enhancement (fixed)

Add some more pxd files for flint

Reported by: jpflori Owned by:
Priority: major Milestone: sage-8.1
Component: packages: standard Keywords: sd87
Cc: roed, jdemeyer, edgarcosta Merged in:
Authors: Jean-Pierre Flori Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 45e7565 (Commits, GitHub, GitLab) Commit: 45e7565a07940febd9769e1f1c7e71bbbca551d5
Dependencies: Stopgaps:

Status badges

Description (last modified by jpflori)

Some more types are needed for #20265:

  • fmpz_poly_q,
  • padic_poly
  • qadic,
  • ...

I also update the padic type which was completely out of date.

Change History (8)

comment:1 Changed 4 years ago by jpflori

  • Authors set to Jean-Pierre Flori
  • Branch set to public/flint_bindings
  • Commit set to 1841735e9134e3057c82a9a216c75281de0b502d

New commits:

​38ed02fAdd some flint types.
​7202798Flint qadic type.
​4c178b3Flint padic_poly type.
​1841735Flint fmpz_poly_q type.

comment:2 Changed 4 years ago by git

  • Commit changed from 1841735e9134e3057c82a9a216c75281de0b502d to 45e7565a07940febd9769e1f1c7e71bbbca551d5

Branch pushed to git repo; I updated commit sha1. New commits:

​80eb8f7Fix cython macro conversion.
​45e7565Flint updated padic type.

comment:3 Changed 4 years ago by jpflori

  • Status changed from new to needs_review

comment:4 Changed 4 years ago by jpflori

  • Cc roed jdemeyer edgarcosta added
  • Description modified (diff)

comment:5 Changed 4 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

I haven't checked whether all declarations are actually correct, but if this works for you...

comment:6 Changed 4 years ago by jpflori

I semi automatically converted the header files. Maybe putting this into a script would be a good idea. And putting the pxd files into a cyflint package.

comment:7 Changed 4 years ago by jpflori

  • Keywords sd87 added

comment:8 Changed 4 years ago by vbraun

  • Branch changed from public/flint_bindings to 45e7565a07940febd9769e1f1c7e71bbbca551d5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.