Changes between Initial Version and Version 5 of Ticket #23450


Ignore:
Timestamp:
07/19/17 05:14:17 (23 months ago)
Author:
caruso
Comment:

Ok, I've moved the code to the category (CDVF and CDVR) as you suggested.

I've also tried to be more rigourous regarding precision and figured out what is the correct precision on the transformation matrices. (My first implementation was too optimistic.) Actually, it turns out that finding the optimal precision is costly, except in the particular case where the input matrix is given at flat precision (i.e. all the entries are given at the same precision). For this reason, I've overestimated the loss of precision for a general input matrix (by reducing to the case of flat precision).

I've also removed the method that computes the determinant of a matrix because again it only worked for matrices given at flat precision.

The ticket is ready for review.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23450

    • Property Status changed from new to needs_review
    • Property Commit changed from to 595bc117c7becc12c9e6afcefcc372b46320384e
    • Property Component changed from PLEASE CHANGE to padics
    • Property Branch changed from to u/caruso/padic_smith
  • Ticket #23450 – Description

    initial v5  
    11Currently Smith form are not implemented over inexact rings.
    22
    3 This ticket provides a (currently unoptimized) implementation of Smith normal form over complete discrete valuation rings/fields (e.g. p-adic rings/fields), together with a new implementation of the method `determinant` making use of Smith normal form and improving this way its behaviour regarding precision.
     3This ticket provides a (currently unoptimized) implementation of Smith normal form over complete discrete valuation rings/fields (e.g. p-adic rings/fields).