Changes between Initial Version and Version 1 of Ticket #23450, comment 31
 Timestamp:
 Jul 21, 2017, 10:57:31 PM (5 years ago)
Legend:
 Unmodified
 Added
 Removed
 Modified

Ticket #23450, comment 31
initial v1 1 1 Ok for factoring the code this way if you prefer. 2 2 3 However, I think that the current code doesn't output the expected answer for matrices over Qp with `integral=None` . In that case, I would say that the entries of Smith normal norm should all be 0 or 1.3 However, I think that the current code doesn't output the expected answer for matrices over Qp with `integral=None` (though I haven't checked it). In that case, I would say that the entries of Smith normal norm should all be 0 or 1. 4 4 5 5 In the doctest, I think that we should precise that we require (1) that the matrices U and V are invertible over the subring and (2) that d_{i+1}/d_i lies in the subring for all i.