Changes between Initial Version and Version 1 of Ticket #23450, comment 31


Ignore:
Timestamp:
07/21/17 22:57:31 (22 months ago)
Author:
caruso
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23450, comment 31

    initial v1  
    11Ok for factoring the code this way if you prefer.
    22
    3 However, I think that the current code doesn't output the expected answer for matrices over Qp with `integral=None`. In that case, I would say that the entries of Smith normal norm should all be 0 or 1.
     3However, I think that the current code doesn't output the expected answer for matrices over Qp with `integral=None` (though I haven't checked it). In that case, I would say that the entries of Smith normal norm should all be 0 or 1.
    44
    55In the doctest, I think that we should precise that we require (1) that the matrices U and V are invertible over the subring and (2) that d_{i+1}/d_i lies in the subring for all i.