Opened 4 years ago

Closed 4 years ago

#23413 closed enhancement (fixed)

Move various things to src/sage/cpython

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.1
Component: cython Keywords:
Cc: tscrim Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: ed0d88c (Commits, GitHub, GitLab) Commit: ed0d88c9c42f1f7d10eebba7c4a29e620709072d
Dependencies: #23404 Stopgaps:

Status badges

Description

Anything dealing with low-level Python stuff should be moved to src/sage/cpython.

Change History (5)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/move_various_things_to_src_sage_cpython

comment:2 Changed 4 years ago by jdemeyer

  • Commit set to ed0d88c9c42f1f7d10eebba7c4a29e620709072d
  • Status changed from new to needs_review

New commits:

cf224b7Implement wrapperdescr_call without checking
9a4ef8cWording
ed0d88cMove various things to src/sage/cpython

comment:3 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

I think if someone is using these functions, they know what they are doing and will either find this ticket or can grep their way around. So we do not need to do any hand-holding old code with moving these functions. (I'm just justifying to any future readers of this ticket why we did not deprecate moving these functions.)

LGTM.

comment:4 Changed 4 years ago by jdemeyer

Indeed. These are very technical things, not meant for ordinary users.

comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/move_various_things_to_src_sage_cpython to ed0d88c9c42f1f7d10eebba7c4a29e620709072d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.