Opened 4 years ago

Closed 4 years ago

#23398 closed defect (fixed)

python3 installs duplicate pip/setuptools

Reported by: embray Owned by:
Priority: minor Milestone: sage-8.0
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Erik Bray Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 8dbe39e (Commits, GitHub, GitLab) Commit: 8dbe39eec7eb5b0e8d4c6d2a3c3618d7b62dccf3
Dependencies: Stopgaps:

Status badges

Description

With #22509 it's relatively easy to see what what packages are installing copies of the same file.

The python3 package now installs setuptools+pip automatically when running make install unless Python was configured with --without-ensurepip (or passing ENSUREPIP=no to make).

We have two options here:

  • Use --without-ensurepip when installing python3
  • Do nothing on Python 3 when installing the setuptools and pip packages

I think the first is preferable and more in line with what most packaging systems are likely to do, especially since python 3 can be run without pip.

Change History (3)

comment:1 Changed 4 years ago by embray

  • Authors set to Erik Bray
  • Branch set to u/embray/build/ticket-23398
  • Commit set to 8dbe39eec7eb5b0e8d4c6d2a3c3618d7b62dccf3
  • Status changed from new to needs_review

Here's a fix using the first approach of --without-ensurepip. I think this is most straightforward, but I'd hear arguments (if any) for the other approach.

This also installs a separate Valgrind suppression file for Python 3, since it was otherwise clobbering the one from Python 2.

There are also issues with the scripts installed by python2/3, but I will handle that in a separate issue.


New commits:

982eb5cDisable pip installation when installing Python 3; see https://trac.sagemath.org/ticket/23398
8dbe39eDon't override the valgrind suppression file from python2; add a separate one for Python 3

comment:2 Changed 4 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:3 Changed 4 years ago by vbraun

  • Branch changed from u/embray/build/ticket-23398 to 8dbe39eec7eb5b0e8d4c6d2a3c3618d7b62dccf3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.