Opened 4 years ago

Closed 4 years ago

#23389 closed enhancement (fixed)

Some curation in semidefinite programming html doc

Reported by: mforets Owned by:
Priority: major Milestone: sage-8.0
Component: numerical Keywords: documentation, semidefinite programming
Cc: Merged in:
Authors: Marcelo Forets Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 6775aa3 (Commits, GitHub, GitLab) Commit: 6775aa3ba4d71e75df1f696961ffa8494011627d
Dependencies: Stopgaps:

Status badges

Description

to do a couple of trivial docstring fixes in sdp.pyx.

Change History (10)

comment:1 Changed 4 years ago by mforets

the hyperlink to default_sdp_solver() is not available in ​semidefinite program because the file generic_sdp_backend.pyx is not shown. notice that the generic backend for ​MILP is included in the html reference. i suggest that we also include the one for SDP.

comment:2 Changed 4 years ago by mforets

  • Authors set to Marcelo Forets
  • Branch set to u/mforets/23389
  • Commit set to 64996b7bb33c8b8c2f337784c6c51f47eacf9e20

New commits:

​ab6d617typos in paragraphs
​01ea990add generic_sdp_backend to html ref manual
​64996b7typeset some equations

comment:3 Changed 4 years ago by git

  • Commit changed from 64996b7bb33c8b8c2f337784c6c51f47eacf9e20 to 8d5131be792ff029995850b8266cec7f595d9334

Branch pushed to git repo; I updated commit sha1. New commits:

​8d5131badd missing INPUT and full stops

comment:4 Changed 4 years ago by mforets

  • Status changed from new to needs_review

comment:5 follow-up: Changed 4 years ago by chapoton

I think there should be an empty line after 

+        .. MATH::

comment:6 in reply to: ↑ 5 Changed 4 years ago by mforets

Replying to chapoton:

I think there should be an empty line after 

+        .. MATH::

the html doc displays fine even without the empty line between the directive and the equation, but let's add it to be consistent with most other places.

comment:7 Changed 4 years ago by git

  • Commit changed from 8d5131be792ff029995850b8266cec7f595d9334 to 6775aa3ba4d71e75df1f696961ffa8494011627d

Branch pushed to git repo; I updated commit sha1. New commits:

​6775aa3add extra space in MATH environments

comment:8 follow-up: Changed 4 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok

comment:9 in reply to: ↑ 8 Changed 4 years ago by mforets

Replying to chapoton:

ok

Thanks for reviewing!

comment:10 Changed 4 years ago by vbraun

  • Branch changed from u/mforets/23389 to 6775aa3ba4d71e75df1f696961ffa8494011627d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.