Opened 2 years ago

Closed 2 years ago

#23382 closed enhancement (fixed)

Clean up matroid constructor

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.0
Component: matroid theory Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Stefan van Zwam
Report Upstream: N/A Work issues:
Branch: 23a7260 (Commits) Commit: 23a7260e164e8adc1c37fc531f6cd32155501717
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

Some basic clean up of the matroid constructor. In particular, use normal variables like groundset instead of kwds['groundset']. Simplify the code and add more doctests for errors.

I'm particularly proud of this: 

 2 files changed, 235 insertions(+), 256 deletions(-)

This is -21 lines despite adding several doctests.

Change History (8)

comment:1 Changed 2 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 2 years ago by jdemeyer

  • Branch set to u/jdemeyer/clean_up_matroid_constructor

comment:3 Changed 2 years ago by jdemeyer

  • Commit set to 23a7260e164e8adc1c37fc531f6cd32155501717
  • Status changed from new to needs_review

New commits:

​23a7260Clean up matroid constructor

comment:4 Changed 2 years ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 2 years ago by jdemeyer

  • Description modified (diff)

comment:6 Changed 2 years ago by Stefan

  • Reviewers set to Stefan van Zwam
  • Status changed from needs_review to positive_review

comment:7 Changed 2 years ago by Stefan

Clean code, all doctests pass. Nice work! It gets my positive review.

comment:8 Changed 2 years ago by vbraun

  • Branch changed from u/jdemeyer/clean_up_matroid_constructor to 23a7260e164e8adc1c37fc531f6cd32155501717
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.