Opened 3 years ago
Closed 2 years ago
#23381 closed enhancement (fixed)
Construct matroid using RevLexIndex encoding
Reported by:  jdemeyer  Owned by:  

Priority:  major  Milestone:  sage8.1 
Component:  matroid theory  Keywords:  
Cc:  Stefan, yomcat, tscrim  Merged in:  
Authors:  Jeroen Demeyer  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  762bc74 (Commits)  Commit:  762bc742e2347c1b5667f41f2fa557f8f5799cdb 
Dependencies:  Stopgaps: 
Description
Construct matroids using the encoding from http://wwwimai.is.s.utokyo.ac.jp/~ymatsu/matroid/index.html explained in detail in http://www.springerlink.com/content/83h55338386k3327/
Change History (15)
comment:1 Changed 3 years ago by
 Dependencies set to #23382
comment:2 Changed 3 years ago by
 Branch set to u/jdemeyer/ticket/23381
comment:3 Changed 3 years ago by
 Commit set to 37c790d3da95fdda06ea586cd95eb0e4240b4069
 Status changed from new to needs_review
comment:4 Changed 3 years ago by
 Cc Stefan added
comment:5 Changed 2 years ago by
 Cc yomcat tscrim added
 Milestone changed from sage8.0 to sage8.1
comment:6 Changed 2 years ago by
Needs a rebase. Also, if you could move the references to the master list.
comment:7 Changed 2 years ago by
 Dependencies #23382 deleted
 Status changed from needs_review to needs_work
comment:8 Changed 2 years ago by
 Commit changed from 37c790d3da95fdda06ea586cd95eb0e4240b4069 to e3c41c3a5c2b17b5449ec2acd5c9f09dc0980a8a
comment:9 Changed 2 years ago by
 Status changed from needs_work to needs_review
comment:10 followup: ↓ 11 Changed 2 years ago by
 Reviewers set to Travis Scrimshaw
Thank you. I know this is probably bikeshedding, but I feel like the missing inputs should raise a ValueError
instead of a TypeError
because the value is missing. However, I don't have a strong opinion, so no matter which you think is better, you can set a positive review on my behalf once you also break this long line:
.. [MMIB2012] \Y. Matsumoto, S. Moriyama, H. Imai, D. Bremner:  Matroid Enumeration for Incidence Geometry, Discrete and Computational Geometry, vol. 47, issue 1, pp. 1743, 2012. + Matroid Enumeration for Incidence Geometry, + Discrete and Computational Geometry, + vol. 47, issue 1, pp. 1743, 2012.
comment:11 in reply to: ↑ 10 ; followup: ↓ 12 Changed 2 years ago by
Replying to tscrim:
Thank you. I know this is probably bikeshedding, but I feel like the missing inputs should raise a
ValueError
instead of aTypeError
because the value is missing.
Python uses TypeError
whenever a function is called with the wrong arguments. By analogy I'm raising TypeError
here.
comment:12 in reply to: ↑ 11 Changed 2 years ago by
Replying to jdemeyer:
Replying to tscrim:
Thank you. I know this is probably bikeshedding, but I feel like the missing inputs should raise a
ValueError
instead of aTypeError
because the value is missing.Python uses
TypeError
whenever a function is called with the wrong arguments. By analogy I'm raisingTypeError
here.
Ah, right. Thanks.
If you could just break that one long line, then positive review.
comment:13 Changed 2 years ago by
 Commit changed from e3c41c3a5c2b17b5449ec2acd5c9f09dc0980a8a to 762bc742e2347c1b5667f41f2fa557f8f5799cdb
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
762bc74  Put references in master references file

comment:14 Changed 2 years ago by
 Status changed from needs_review to positive_review
comment:15 Changed 2 years ago by
 Branch changed from u/jdemeyer/ticket/23381 to 762bc742e2347c1b5667f41f2fa557f8f5799cdb
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
Clean up matroid constructor
Construct matroid using RevLexIndex encoding